get rid of models/captcha.php and replace with base64 captcha function.#143
get rid of models/captcha.php and replace with base64 captcha function.#143r3wt merged 3 commits intouserfrosting:masterfrom r3wt:master
Conversation
|
@alexweissman whats up? if you want, i can squash the obfuscation commit, although to me it seems to be damn near the perfect amount of obfuscation. i think we should probably go ahead and extend this captcha system to have an ajax method to get a new token, similar to how recaptcha works, because sometimes there are those captchas that are too hard for the human eye to interpret. i see there is another open pull from @lilfade too. been busy with work lately? |
|
I think he's busy as shit with school atm, i think both commits are fine you wanna give the upgrade pull a test on hhvm and see how it works out it seems to work fine on apache2/php. The steps to test are on the pull request. |
get rid of models/captcha.php and replace with base64 captcha function.
|
@lilfade Confirmed working in hhvm. i merged the pull(didn't know i was allowed to merge, cool). if we see problems we will revert it. |
|
Yea when we were added as contributors the other day it add those permissions to the repo to us. Thanks for testing it out for me ^_^ |
|
Yeah, my classes are ramping up, plus I'm getting a ton of work from my business. I'm delegating more responsibility to you guys, first because you guys are great and have contributed a lot, but also because its getting to the point where its more than I can handle alone ;-) @r3wt thanks for merging the commits. @lilfade, I know you still have an outstanding pull request. Do you want to manually merge that in? I also have some outstanding commits. Its actually a pretty cool feature, I just haven't had time to fully test it... |
|
Yea it's no huge change just changes the file list to be from the configuration file to the db to be easier for plugin to add to the file array, another field to the settings array for version for the update system to use and anyone else that needs a versions (again maybe plugins?) And of course the update folder for people on 0.2.1 to goto 0.2.2. I can merge it though if you want to test your changes you can create a new branch to test mergability for your changes and we can test it as well. |
addresses #142 by eliminating the need for models/captcha.php