#937, #921 improve evaluation of proxy configuration, allow empty port#951
Merged
helloanoop merged 3 commits intousebruno:mainfrom Nov 18, 2023
Merged
Conversation
… allow empty proxy port
helloanoop
reviewed
Nov 12, 2023
| const dataBuffer = Buffer.from(response.data); | ||
| // Parse the charset from content type: https://stackoverflow.com/a/33192813 | ||
| const charset = /charset=([^()<>@,;:\"/[\]?.=\s]*)/i.exec(response.headers['Content-Type'] || ''); | ||
| const charset = /charset=([^()<>@,;:"/[\]?.=\s]*)/i.exec(response.headers['Content-Type'] || ''); |
Contributor
Author
There was a problem hiding this comment.
Inside brackets [...] you don't need to escape "
And my IntelliJ really helps me here.
Contributor
|
Thanks for taking care of this @mirkogolze ! |
This was referenced Jan 19, 2024
bijin-bruno
added a commit
that referenced
this pull request
Feb 13, 2026
* feat: button storybook * feat: update button component with new rounded options and story * fix: pasting request ito parent folder even if request is selected (#6446) * Add right-click context menu to request tabs with MenuDropdown # (#6502) * refactor: replace Dropdown with MenuDropdown in RequestTab component; update Dropdown props handling in Dropdown component * refactor: remove Portal import and simplify menuDropdown rendering in RequestTab component * refactor: streamline RequestTabMenu functionality and improve tab closing methods with async handling * refactor: enhance Dropdown and MenuDropdown components with improved props handling and styling adjustments * refactor: enhance Dropdown and MenuDropdown components by improving structure and removing unused styles * refactor: update Dropdown and MenuDropdown components to append to sidebar sections container for improved layout * refactor: integrate dropdownContainerRef for improved MenuDropdown positioning in RequestTabs and Sidebar components * refactor: update Dropdown component to include 'tippy-box' class for e2e test selections * refactor: update dropdown item selection logic in selectRequestPaneTab function for improved accuracy * refactor: add fixed positioning to popperOptions in Collection and CollectionItem components for improved dropdown behavior --------- Co-authored-by: sanjai <sanjai@usebruno.com> * export & import in opencollection format (#6329) --------- Co-authored-by: Anoop M D <anoop.md1421@gmail.com> Co-authored-by: Anoop M D <anoop@usebruno.com> Co-authored-by: Pooja <pooja@usebruno.com> Co-authored-by: Abhishek S Lal <abhishek@usebruno.com> Co-authored-by: sanjai <sanjai@usebruno.com> Co-authored-by: naman-bruno <naman@usebruno.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no proxy configuration is given on collection level, check for the global proxy configuration.
Allow empty port for proxy configuration
Contribution Checklist: