packages/bruno-js/tests/runtime.spec.js (1)

278-281: No test covers the QuickJS runtime path for isJson.

The new json getter in the QuickJS shim (test.js) is the other half of this fix, but every test in this suite uses the default 'nodevm' runtime. A failure in the IIFE (e.g., wrong prototype lookup, Object.defineProperty descriptor issue) would go undetected here. Since runAssertions already accepts runtime, it's a one-liner to add a parallel case.

       it('should pass for a plain object', () => {
         const results = runAssertions(
           [{ name: 'res.body', value: 'isJson', enabled: true }],
           makeResponse({ id: 1, name: 'test' })
         );
         expect(results[0].status).toBe('pass');
       });
+
+      it('should pass for a plain object (quickjs runtime)', () => {
+        const results = runAssertions(
+          [{ name: 'res.body', value: 'isJson', enabled: true }],
+          makeResponse({ id: 1, name: 'test' }),
+          'quickjs'
+        );
+        expect(results[0].status).toBe('pass');
+      });
+
+      it('should fail for an array (quickjs runtime)', () => {
+        const results = runAssertions(
+          [{ name: 'res.body', value: 'isJson', enabled: true }],
+          makeResponse([1, 2, 3]),
+          'quickjs'
+        );
+        expect(results[0].status).toBe('fail');
+      });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/bruno-js/tests/runtime.spec.js` around lines 278 - 281, Add a test
invocation that exercises the QuickJS runtime path by calling the existing
runAssertions helper with runtime set to 'quickjs' (e.g., new AssertRuntime({
runtime: 'quickjs' }) via runAssertions(assertions, response, 'quickjs')) so the
QuickJS shim's json getter and IIFE code path (including prototype lookup and
Object.defineProperty behavior) are executed; modify the relevant test block to
run the same assertions twice — once with the default 'nodevm' and once with
'quickjs' — to ensure isJson behavior is covered.

packages/bruno-js/src/sandbox/quickjs/shims/test.js (1)

70-75: Missing return this; breaks post-assertion chaining.

Chai's addProperty wrapper automatically returns this when the callback returns undefined — raw Object.defineProperty skips that wrapper, so any user who writes expect(obj).to.be.json.and.have.property(...) will get a TypeError in the QuickJS sandbox. Current usages are all terminal so it doesn't bite today, but it creates an inconsistency with the node-vm path where chai.Assertion.addProperty is used (which is chainable by design).

♻️ Proposed fix

         get: function () {
           var obj = this._obj;
           var isJson = typeof obj === 'object' && obj !== null && !Array.isArray(obj) &&
             Object.prototype.toString.call(obj) === '[object Object]';
           this.assert(isJson, 'expected #{this} to be JSON', 'expected #{this} not to be JSON');
+          return this;
         },

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/bruno-js/src/sandbox/quickjs/shims/test.js` around lines 70 - 75,
The getter defined in the Object.defineProperty block (the get: function() that
reads this._obj and calls this.assert) must return this to preserve Chai-style
chaining; update the get function for the JSON assertion to append a `return
this;` after the `this.assert(...)` call so `expect(obj).to.be.json.and...`
continues to work like the chai.Assertion.addProperty path.