packages/bruno-electron/src/utils/workspace-config.js (2)

341-341: addCollectionToWorkspace stores the path differently from addApiSpecToWorkspace.

Line 341 posixifies and stores the raw (potentially absolute) path. addApiSpecToWorkspace (line 459) runs makeRelativePath first, ensuring a relative POSIX path is stored in the YAML. For consistency, and to avoid embedding absolute Windows paths (C:/...) into workspace files (which break when the file is opened on macOS/Linux — path.isAbsolute('C:/...') returns false on POSIX), this function should do the same.

♻️ Suggested refactor

 const normalizedCollection = {
   name: collection.name.trim(),
-  path: posixifyPath(collection.path.trim())
+  path: makeRelativePath(workspacePath, collection.path.trim())
 };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/bruno-electron/src/utils/workspace-config.js` at line 341,
addCollectionToWorkspace currently stores collection.path after only posixifying
it, which can preserve absolute Windows paths; update addCollectionToWorkspace
to mirror addApiSpecToWorkspace by passing collection.path through
makeRelativePath(...) before posixifyPath(...) so the YAML stores a relative
POSIX path; locate the collection.path assignment in addCollectionToWorkspace
and replace the direct posixifyPath(collection.path.trim()) usage with
posixifyPath(makeRelativePath(collection.path).trim()) (or equivalent ordering
used by addApiSpecToWorkspace) to ensure consistent cross-platform relative
paths.

---

8-9: Consider a defensive type guard in posixifyPath.

p.replace(...) will throw if p is null, undefined, or a non-string. All current call sites are properly guarded (ternary checks / isValidCollectionEntry pre-validation), so there's no immediate risk — but a guard makes the helper self-documenting about its contract.

🛡️ Suggested guard

-const posixifyPath = (p) => p.replace(/\\/g, '/');
+const posixifyPath = (p) => (typeof p === 'string' ? p.replace(/\\/g, '/') : p);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/bruno-electron/src/utils/workspace-config.js` around lines 8 - 9,
The helper posixifyPath currently calls p.replace(...) which will throw if p is
null/undefined or not a string; add a defensive type guard at the start of
posixifyPath (e.g., check typeof p === 'string') and if the check fails return
the original value (or an empty string if you prefer) so the function never
throws on bad inputs; update any tests or callers if they rely on an exception,
and keep the function name posixifyPath unchanged so callers like
isValidCollectionEntry continue to work.