Skip to content

fix: update protobuf and import path handling in opencollection#7166

Merged
bijin-bruno merged 1 commit intousebruno:mainfrom
naman-bruno:bugfix/yml-proto
Feb 17, 2026
Merged

fix: update protobuf and import path handling in opencollection#7166
bijin-bruno merged 1 commit intousebruno:mainfrom
naman-bruno:bugfix/yml-proto

Conversation

@naman-bruno
Copy link
Collaborator

@naman-bruno naman-bruno commented Feb 17, 2026 •
edited by coderabbitai bot
Loading

Description

Fixes: #6760

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Bug Fixes

    • Fixed misspelling in protobuf configuration property name.

  • Refactor

    • Updated protobuf import path configuration to use an enabled flag instead of a disabled flag.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

Walkthrough

Changes invert the protobuf import paths configuration logic from disabled to enabled flag and fix a typo (protofFiles → protoFiles) across converter and file store modules handling collection serialization and deserialization.

Changes

Cohort / File(s) Summary
Type Definitions
packages/bruno-converters/src/opencollection/types.ts		 Updated BrunoConfig.protobuf.importPaths array item type from { path: string; disabled?: boolean } to { path: string; enabled?: boolean }.
Converter Logic
packages/bruno-converters/src/opencollection/bruno-to-opencollection.ts, packages/bruno-converters/src/opencollection/opencollection-to-bruno.ts		 Inverted the flag interpretation: disabled flag now computed as p.disabled !== true when exporting as enabled, and conditional checks updated to test p.enabled explicitly false instead of p.disabled truthiness.
YAML File Store
packages/bruno-filestore/src/formats/yml/parseCollection.ts, packages/bruno-filestore/src/formats/yml/stringifyCollection.ts		 Fixed typo protofFiles → protoFiles; inverted and renamed disabled → enabled with logic importPath.disabled !== true; extended stringify to handle both protoFiles and importPaths separately with conditional writing for importPaths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • PR #6726: Directly related rename/inversion of protobuf importPaths affecting grpc includeDirs filtering logic and import-path selection.

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • bijin-bruno

Poem

🚀 From disabled to enabled, the logic flips clean,
A typo corrected—protoFiles now seen,
Five files aligned with inverted intent,
Proto configurations now properly sent! 📝✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix: update protobuf and import path handling in opencollection' accurately reflects the main changes: converting disabled flags to enabled flags and fixing the protoFiles typo across multiple files.
Linked Issues check ✅ Passed The PR directly addresses issue #6760 by fixing protobuf configuration serialization and deserialization logic. The changes ensure proto files and import paths are correctly persisted when saving collections.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing protobuf handling: disabled→enabled flag semantics, protoFiles typo fixes, and serialization/deserialization logic across four closely related files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bijin-bruno bijin-bruno merged commit 5021226 into usebruno:main Feb 17, 2026
8 checks passed
bijin-bruno pushed a commit that referenced this pull request Feb 17, 2026
@naman-bruno @bijin-bruno
fix: update protobuf and import path handling in opencollection (#7166)
db61267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bijin-bruno bijin-bruno bijin-bruno approved these changes

@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner

@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner

+1 more reviewer

@sanish-bruno sanish-bruno sanish-bruno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding proto file(s) and then saving them doesn't keep them in the files table/list

3 participants

@naman-bruno @sanish-bruno @bijin-bruno