fix: update linting commands to use npx for better compatibility by kanakkholwal · Pull Request #6840 · usebruno/bruno

kanakkholwal · 2026-01-16T17:28:01Z

Description

fix for #6839

Contribution Checklist:

I've used AI significantly to create this pull request
The pull request only addresses one issue or adds one feature.
The pull request does not introduce any breaking changes
I have added screenshots or gifs to help explain the change if applicable.
I have read the contribution guidelines.
Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

Chores
- Added a new development dependency to enable setting environment-based Node options for tooling.
- Updated linting scripts to apply Node memory limits via environment variables and invoke ESLint through the package runner, improving consistency and reliability of lint executions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-16T17:28:09Z

Walkthrough

Replaced the node wrapper and command-substitution in package.json lint scripts with cross-env NODE_OPTIONS="--max_old_space_size=4096" npx eslint (and --fix), and added cross-env@10.1.0 to devDependencies.

Changes

Cohort / File(s)	Change Summary
npm scripts & deps `package.json`	Added devDependency `cross-env@10.1.0`. Updated `scripts.lint` and `scripts["lint:fix"]` to use `cross-env NODE_OPTIONS="--max_old_space_size=4096" npx eslint` (and `--fix`) instead of `node --max_old_space_size=4096 $(npx which eslint)`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

helloanoop
lohit-bruno

Poem

cross-env whispers to Node's heap,
npx wakes eslint from its sleep.
Shell tricks gone, the command is clean,
small change, smoother linting scene. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating linting commands to use npx for cross-platform compatibility, which aligns with the PR's purpose of fixing PowerShell compatibility issues.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

kanakkholwal · 2026-01-16T17:29:33Z

@coderabbitai review

coderabbitai · 2026-01-16T17:29:39Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot

Pull request overview

This pull request updates the ESLint invocation commands in package.json to use npx's built-in --node-options flag instead of shell command substitution, improving cross-platform compatibility while maintaining the same memory allocation configuration.

Changes:

Replaced shell command substitution syntax with npx native option passing for both lint and lint:fix commands
Maintained the same memory allocation setting (4096MB) for ESLint execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sid-bruno · 2026-01-21T06:40:26Z

I've made changes, can you verify it's working for you on Windows?

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@package.json`:
- Around line 86-87: Update the package.json npm scripts "lint" and "lint:fix"
to use JSON-escaped double quotes for NODE_OPTIONS instead of single quotes so
Windows cmd.exe parses the option correctly; locate the "lint" and "lint:fix"
script entries and replace NODE_OPTIONS='--max_old_space_size=4096' with the
JSON-escaped form NODE_OPTIONS=\"--max_old_space_size=4096\" in both scripts.

package.json

kanakkholwal · 2026-01-21T16:17:43Z

I've made changes, can you verify it's working for you on Windows?

Yes they are working! @sid-bruno

…bruno#6840) * fix: update linting commands to use npx for better compatibility * chore: update cross-env version and adjust lint scripts * Fix lint command syntax in package.json --------- Co-authored-by: Sid <siddharth@usebruno.com>

fix: update linting commands to use npx for better compatibility

522ee27

pull-request-size bot added the size/XS label Jan 16, 2026

kanakkholwal marked this pull request as ready for review January 16, 2026 17:30

kanakkholwal requested review from bijin-bruno, helloanoop, lohit-bruno and naman-bruno as code owners January 16, 2026 17:30

Copilot AI review requested due to automatic review settings January 16, 2026 17:30

Copilot started reviewing on behalf of kanakkholwal January 16, 2026 17:31 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

chore: update cross-env version and adjust lint scripts

acbed25

coderabbitai bot reviewed Jan 21, 2026

View reviewed changes

package.json Outdated Show resolved Hide resolved

Fix lint command syntax in package.json

045f647

sid-bruno merged commit 0fb605a into usebruno:main Jan 21, 2026
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update linting commands to use npx for better compatibility#6840

fix: update linting commands to use npx for better compatibility#6840
sid-bruno merged 3 commits intousebruno:mainfrom
kanakkholwal:fix/lint-script-powershell-compatibility

kanakkholwal commented Jan 16, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

kanakkholwal commented Jan 16, 2026

Uh oh!

coderabbitai bot commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

sid-bruno commented Jan 21, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

kanakkholwal commented Jan 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kanakkholwal commented Jan 16, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contribution Checklist:

Publishing to New Package Managers

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

kanakkholwal commented Jan 16, 2026

Uh oh!

coderabbitai bot commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

sid-bruno commented Jan 21, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kanakkholwal commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kanakkholwal commented Jan 16, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 16, 2026 •

edited

Loading

kanakkholwal commented Jan 21, 2026 •

edited

Loading