Skip to content

skip loading CA certificates when SSL verification is disabled#6829

Merged
bijin-bruno merged 1 commit intousebruno:mainfrom
sreelakshmi-bruno:fix-cert-loading-when-ssl-off
Jan 21, 2026
Merged

skip loading CA certificates when SSL verification is disabled#6829
bijin-bruno merged 1 commit intousebruno:mainfrom
sreelakshmi-bruno:fix-cert-loading-when-ssl-off

Conversation

@sreelakshmi-bruno
Copy link
Collaborator

@sreelakshmi-bruno sreelakshmi-bruno commented Jan 16, 2026 •
edited
Loading

Description

  • Skip loading CA certificates when SSL/TLS verification is disabled
  • Fixes performance issue where requests take 10-14 seconds with large certificate stores
  • Certificates are only loaded when shouldVerifyTls() returns true

Jira

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Refactor
    • Optimized certificate handling in network requests for improved performance when SSL verification is disabled.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026 •
edited
Loading

Walkthrough

The change modifies certificate loading in the cert-utils module to be conditional on TLS verification being enabled. CA certificates are now initialized to default values and only loaded when shouldVerifyTls() returns true, optimizing I/O operations when SSL validation is disabled.

Changes

Cohort / File(s) Summary
TLS Certificate Loading
packages/bruno-electron/src/ipc/network/cert-utils.js		 Wrapped CA certificate loading logic in a shouldVerifyTls() guard clause; caCertificates and caCertificatesCount now initialize to default/empty values before conditional population; fallback used when assigning to httpsAgentRequestFields.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

size/L

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • naman-bruno
  • bijin-bruno

Poem

Guard clauses stand their ground,
When TLS verification's found,
Certs load swift—but only when,
The trust is real, again and again. 🔐

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: conditionally skipping CA certificate loading when SSL verification is disabled, which aligns with the primary objective of improving performance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bijin-bruno bijin-bruno merged commit 154c45d into usebruno:main Jan 21, 2026
7 of 8 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jan 30, 2026
Merged
6 tasks
FraCata00 pushed a commit to FraCata00/bruno that referenced this pull request Feb 9, 2026
@sreelakshmi-bruno @FraCata00
skip loading CA certificates when SSL verification is disabled (usebr…
612cdb9 
…uno#6829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bijin-bruno bijin-bruno bijin-bruno approved these changes

@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner

@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner

@naman-bruno naman-bruno Awaiting requested review from naman-bruno naman-bruno is a code owner

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sreelakshmi-bruno @bijin-bruno