Skip to content

fix: resolve Load Request button error when loading large collection …#6809

Merged
bijin-bruno merged 2 commits intousebruno:mainfrom
sreelakshmi-bruno:fix-load-request-button
Jan 14, 2026
Merged

fix: resolve Load Request button error when loading large collection …#6809
bijin-bruno merged 2 commits intousebruno:mainfrom
sreelakshmi-bruno:fix-load-request-button

Conversation

@sreelakshmi-bruno
Copy link
Collaborator

@sreelakshmi-bruno sreelakshmi-bruno commented Jan 14, 2026 •
edited by coderabbitai bot
Loading

Description

Fixed an issue where clicking the "Load Request" button threw the following error instead of loading the collection request file:
"Error invoking remote method 'renderer:load-large-request': TypeError: Cannot read properties of undefined (reading 'format')To run code, enable code execution and file creation in Settings > Capabilities."

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Refactor
    • Improved BRU-format parsing flow so format information is consistently propagated across collection operations, including large-request handling and file parsing.
    • Tightened parsing/serialization paths for more reliable detection and processing of BRU files.
    • No public APIs or exported interfaces were changed.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026 •
edited
Loading

Walkthrough

Threads a format parameter through BRU parsing: updates call sites in collection watcher and IPC to pass format, and changes parseLargeRequestWithRedaction to accept and propagate a format argument.

Changes

Cohort / File(s) Summary
Parsing API & helpers
packages/bruno-electron/src/utils/parse.js		 Signature change: parseLargeRequestWithRedaction(bruContent, format = 'bru'). Passes { format } to parseRequestAndRedactBody and parseRequestViaWorker. JSDoc updated.
IPC parsing call sites
packages/bruno-electron/src/ipc/collection.js		 Propagates format through parseFileByType(fileContent, scopeType, format) and supplies { format: 'bru' } to BRU-specific parsing calls, including parseRequestViaWorker and parseLargeRequestWithRedaction.
Collection watcher integration
packages/bruno-electron/src/app/collection-watcher.js		 Updates BRU large-request handling to call parseLargeRequestWithRedaction(content, 'bru') (previously single-arg). No public API changes.

Sequence Diagram(s)

(omitted — change is limited to threading format parameter and does not introduce a multi-component control-flow worthy of a sequence diagram)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

size/M

Suggested reviewers

  • lohit-bruno
  • bijin-bruno
  • helloanoop

Poem

A tiny flag through parsers sails,
From watcher to worker it trails,
BRU whispers its chosen name,
And parsing flows the same. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main issue fixed in this PR: resolving an error with the Load Request button when handling large collections by properly threading the format parameter through parsing functions.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65a495e and 3f34848.

📒 Files selected for processing (3)
  • packages/bruno-electron/src/app/collection-watcher.js
  • packages/bruno-electron/src/ipc/collection.js
  • packages/bruno-electron/src/utils/parse.js
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/bruno-electron/src/utils/parse.js
  • packages/bruno-electron/src/ipc/collection.js
  • packages/bruno-electron/src/app/collection-watcher.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: SSL Tests - Windows
  • GitHub Check: SSL Tests - macOS
  • GitHub Check: Unit Tests
  • GitHub Check: CLI Tests
  • GitHub Check: SSL Tests - Linux
  • GitHub Check: Playwright E2E Tests

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jan 14, 2026
@bijin-bruno bijin-bruno merged commit 8b1b18c into usebruno:main Jan 14, 2026
8 checks passed
FraCata00 pushed a commit to FraCata00/bruno that referenced this pull request Feb 9, 2026
@sreelakshmi-bruno @FraCata00
fix: resolve Load Request button error when loading large collection … (
67a6b87 
usebruno#6809)

* fix: resolve Load Request button error when loading large collection requests

* scope down to .bru requests
This was referenced Feb 13, 2026
Open
Closed
Closed
This was referenced Feb 24, 2026
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bijin-bruno bijin-bruno bijin-bruno approved these changes

@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner

@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner

@naman-bruno naman-bruno Awaiting requested review from naman-bruno naman-bruno is a code owner

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sreelakshmi-bruno @bijin-bruno