Skip to content

fix: add compute key for virtual table#6807

Merged
sid-bruno merged 1 commit intousebruno:mainfrom
sid-bruno:fix/add-compute-key
Jan 14, 2026
Merged

fix: add compute key for virtual table#6807
sid-bruno merged 1 commit intousebruno:mainfrom
sid-bruno:fix/add-compute-key

Conversation

@sid-bruno
Copy link
Collaborator

@sid-bruno sid-bruno commented Jan 14, 2026 •
edited by coderabbitai bot
Loading

Description

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability and stability of the environment variables list display, particularly when scrolling through large lists.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 14, 2026 07:39
@sid-bruno sid-bruno merged commit 7b28b05 into usebruno:main Jan 14, 2026
8 of 10 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

A single line addition to EnvironmentVariables component that adds a computeItemKey prop to TableVirtuoso, enabling stable item identification during virtualization by leveraging variable.uid.

Changes

Cohort / File(s) Summary
TableVirtuoso Virtualization
packages/bruno-app/src/components/WorkspaceHome/WorkspaceEnvironments/EnvironmentList/EnvironmentDetails/EnvironmentVariables/index.js		 Added computeItemKey prop using variable.uid for stable item identity during list virtualization

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • usebruno/bruno#6790: Directly related TableVirtuoso virtualization changes for stable key computation in the same EnvironmentVariables component.

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • naman-bruno
  • bijin-bruno

Poem

✨ One line added, smooth as glass,
Keys now stable as they pass,
Virtualized without a stall,
Variable.uid guides them all 🎯

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b0f27d0 and 5ed6a3a.

📒 Files selected for processing (1)
  • packages/bruno-app/src/components/WorkspaceHome/WorkspaceEnvironments/EnvironmentList/EnvironmentDetails/EnvironmentVariables/index.js

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the computeItemKey prop to the TableVirtuoso component for proper React key management in the virtual table for workspace environment variables.

Changes:

  • Added computeItemKey prop to TableVirtuoso to use the unique uid field for identifying table rows, preventing potential rendering issues when environment variables are added or removed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

FraCata00 pushed a commit to FraCata00/bruno that referenced this pull request Feb 9, 2026
@sid-bruno @FraCata00
fix: add compute key for virtual table (usebruno#6807)
0d2a44f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner

@bijin-bruno bijin-bruno Awaiting requested review from bijin-bruno bijin-bruno is a code owner

@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner

@naman-bruno naman-bruno Awaiting requested review from naman-bruno naman-bruno is a code owner

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sid-bruno