Skip to content

fix: move yup from peerDependencies to dependencies#6794

Merged
bijin-bruno merged 2 commits intousebruno:mainfrom
gopu-bruno:fix/cli-yup-peer-dependency-6774
Jan 13, 2026
Merged

fix: move yup from peerDependencies to dependencies#6794
bijin-bruno merged 2 commits intousebruno:mainfrom
gopu-bruno:fix/cli-yup-peer-dependency-6774

Conversation

@gopu-bruno
Copy link
Collaborator

@gopu-bruno gopu-bruno commented Jan 13, 2026 •
edited by coderabbitai bot
Loading

Description

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Chores
    • Updated internal dependency configuration for improved package consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026 •
edited
Loading

Walkthrough

Yup was moved from peerDependencies to dependencies in the bruno-schema package configuration. This ensures Yup is automatically installed alongside bruno-schema, resolving installation issues when using package managers like yarn that don't auto-install peer dependencies.

Changes

Cohort / File(s) Summary
Dependency declaration adjustment
packages/bruno-schema/package.json		 Migrated Yup (^0.32.11) from peerDependencies to dependencies, ensuring automatic installation instead of requiring manual setup.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Yup was lost in peer dependency land,
Now bundled tight with a helping hand,
No more manual installs needed here,
Just smooth sailing, crystal clear! 📦✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and clearly summarizes the main change: moving yup from peerDependencies to dependencies in the package.json file.
Linked Issues check ✅ Passed The PR directly addresses issue #6774 by moving yup to dependencies, ensuring the CLI includes all necessary runtime dependencies for global yarn installs.
Out of Scope Changes check ✅ Passed All changes are scoped to resolving the peer dependency issue; only package.json and package-lock.json were modified as intended.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fceb99e and a7e3a02.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • packages/bruno-schema/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: SSL Tests - Linux
  • GitHub Check: SSL Tests - macOS
  • GitHub Check: SSL Tests - Windows
  • GitHub Check: Playwright E2E Tests
  • GitHub Check: CLI Tests
  • GitHub Check: Unit Tests
🔇 Additional comments (1)
packages/bruno-schema/package.json (1)

13-16: LGTM! Correctly fixes the yarn peer dependency issue.

Moving yup from peerDependencies to dependencies ensures it's automatically installed with @usebruno/schema, resolving the runtime failure reported in #6774.

Note: yup 0.32.x is an older major version (1.x is current), but upgrading would be out of scope for this bug fix and could introduce breaking changes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bijin-bruno bijin-bruno merged commit e6a48a7 into usebruno:main Jan 13, 2026
8 checks passed
@bijin-bruno bijin-bruno mentioned this pull request Jan 13, 2026
Closed
5 tasks
FraCata00 pushed a commit to FraCata00/bruno that referenced this pull request Feb 9, 2026
@gopu-bruno @FraCata00
fix: move yup from peerDependencies to dependencies (usebruno#6794)
3d8aedf 
* fix: move yup from peerDependencies to dependencies

* chore: update package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bijin-bruno bijin-bruno bijin-bruno approved these changes

@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner

@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner

@naman-bruno naman-bruno Awaiting requested review from naman-bruno naman-bruno is a code owner

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot use bruno-cli v3 when installed with yarn without installing yup manually

2 participants

@gopu-bruno @bijin-bruno