packages/bruno-electron/src/index.js (2)

224-233: Excellent debounce implementation that addresses the lag issue.

The trailing debounce pattern is correctly implemented and will eliminate the performance problem of saving on every move event. The 100ms delay is well-chosen for this use case.

♻️ Optional: Add maximized check inside timeout for edge case

For additional robustness, consider checking the maximized state inside the timeout callback as well, in case the window is maximized during the 100ms delay:

 const handleBoundsChange = () => {
-  if (!mainWindow.isMaximized()) {
-    if (boundsTimeout) {
-      clearTimeout(boundsTimeout);
-    }
-    boundsTimeout = setTimeout(() => {
+  if (boundsTimeout) {
+    clearTimeout(boundsTimeout);
+  }
+  boundsTimeout = setTimeout(() => {
+    if (!mainWindow.isMaximized()) {
       saveBounds(mainWindow);
-    }, 100);
-  }
+    }
+  }, 100);
 };

This ensures bounds are only saved if the window is still not maximized when the timeout fires.

---

224-233: Consider cleanup on window lifecycle events.

While not critical, clearing the timeout on window close and maximize events would be more defensive.

♻️ Optional: Add timeout cleanup

On window close (around line 258):

 mainWindow.on('close', (e) => {
   e.preventDefault();
+  if (boundsTimeout) {
+    clearTimeout(boundsTimeout);
+  }
   terminalManager.cleanup(mainWindow.webContents);
   ipcMain.emit('main:start-quit-flow');
 });

On maximize (around line 239):

 mainWindow.on('maximize', () => {
+  if (boundsTimeout) {
+    clearTimeout(boundsTimeout);
+  }
   saveMaximized(true);
   mainWindow.webContents.send('main:window-maximized');
 });

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: naman-bruno
Repo: usebruno/bruno PR: 6407
File: packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js:5-41
Timestamp: 2025-12-17T21:41:24.730Z
Learning: Do not suggest PropTypes validation for React components in the Bruno codebase. The project does not use PropTypes, so reviews should avoid proposing PropTypes and rely on the existing typing/validation approach (e.g., TypeScript or alternative runtime checks) if applicable. This guideline applies broadly to all JavaScript/JSX components in the repo.