Skip to content

chore: minor url bar alignment fixes and refactor#6714

Merged
bijin-bruno merged 1 commit intomainfrom
fix/urlbar-alignment-patch-1
Jan 7, 2026
Merged

chore: minor url bar alignment fixes and refactor#6714
bijin-bruno merged 1 commit intomainfrom
fix/urlbar-alignment-patch-1

Conversation

@bijin-bruno
Copy link
Collaborator

@bijin-bruno bijin-bruno commented Jan 7, 2026

Description

Minor url bar alignment fixes and refactor

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

  • Style
    • Adjusted spacing and layout consistency across gRPC, HTTP, and WebSocket query URL interface components.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

Walkthrough

This PR standardizes spacing across multiple RequestPane URL component files by removing and adjusting margin/padding utility classes on input containers, send-request action groups, and infotip elements to refine horizontal and gap-based spacing.

Changes

Cohort / File(s) Summary
GrpcQueryUrl Styling
packages/bruno-app/src/components/RequestPane/GrpcQueryUrl/MethodDropdown/StyledWrapper.js
Removed margin-right: 0.5rem from .method-dropdown-container CSS rule
GrpcQueryUrl Layout
packages/bruno-app/src/components/RequestPane/GrpcQueryUrl/index.js
Removed pr-2 from input container; replaced mr-2 with mx-2 on send-request container
QueryUrl Layout
packages/bruno-app/src/components/RequestPane/QueryUrl/index.js
Removed pr-2 from URL container; added mx-2 and gap-3 to send-request container; removed mr-3 from infotip elements
WsQueryUrl Layout
packages/bruno-app/src/components/RequestPane/WsQueryUrl/index.js
Removed pr-2 from outer container; replaced mr-2 with gap-3/mx-3 on action areas; removed mr-3 from infotip and control groups

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • lohit-bruno
  • helloanoop
  • naman-bruno

Poem

✨ Margins trimmed and gaps aligned,
CSS utilities refined,
Spacing flows from left to right,
Layout breathes, the spacing tight! 🎨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the core changes: CSS alignment and spacing adjustments across multiple URL bar components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dcbf38b and 03873af.

📒 Files selected for processing (4)
  • packages/bruno-app/src/components/RequestPane/GrpcQueryUrl/MethodDropdown/StyledWrapper.js
  • packages/bruno-app/src/components/RequestPane/GrpcQueryUrl/index.js
  • packages/bruno-app/src/components/RequestPane/QueryUrl/index.js
  • packages/bruno-app/src/components/RequestPane/WsQueryUrl/index.js
💤 Files with no reviewable changes (1)
  • packages/bruno-app/src/components/RequestPane/GrpcQueryUrl/MethodDropdown/StyledWrapper.js
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (CODING_STANDARDS.md)

**/*.{js,jsx,ts,tsx}: Use 2 spaces for indentation. No tabs, just spaces
Stick to single quotes for strings. For JSX/TSX attributes, use double quotes (e.g., )
Always add semicolons at the end of statements
No trailing commas
Always use parentheses around parameters in arrow functions, even for single params
For multiline constructs, put opening braces on the same line, and ensure consistency. Minimum 2 elements for multiline
No newlines inside function parentheses
Space before and after the arrow in arrow functions. () => {} is good
No space between function name and parentheses. func() not func ()
Semicolons go at the end of the line, not on a new line
Names for functions need to be concise and descriptive
Add in JSDoc comments to add more details to the abstractions if needed
Add in meaningful comments instead of obvious ones where complex code flow is explained properly

Files:

  • packages/bruno-app/src/components/RequestPane/GrpcQueryUrl/index.js
  • packages/bruno-app/src/components/RequestPane/WsQueryUrl/index.js
  • packages/bruno-app/src/components/RequestPane/QueryUrl/index.js
🧠 Learnings (1)
📚 Learning: 2025-12-17T21:41:24.730Z
Learnt from: naman-bruno
Repo: usebruno/bruno PR: 6407
File: packages/bruno-app/src/components/Environments/ConfirmCloseEnvironment/index.js:5-41
Timestamp: 2025-12-17T21:41:24.730Z
Learning: Do not suggest PropTypes validation for React components in the Bruno codebase. The project does not use PropTypes, so reviews should avoid proposing PropTypes and rely on the existing typing/validation approach (e.g., TypeScript or alternative runtime checks) if applicable. This guideline applies broadly to all JavaScript/JSX components in the repo.

Applied to files:

  • packages/bruno-app/src/components/RequestPane/GrpcQueryUrl/index.js
  • packages/bruno-app/src/components/RequestPane/WsQueryUrl/index.js
  • packages/bruno-app/src/components/RequestPane/QueryUrl/index.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Playwright E2E Tests
  • GitHub Check: Unit Tests
  • GitHub Check: CLI Tests
  • GitHub Check: SSL Tests - Windows
  • GitHub Check: SSL Tests - macOS
  • GitHub Check: SSL Tests - Linux
🔇 Additional comments (3)
packages/bruno-app/src/components/RequestPane/GrpcQueryUrl/index.js (1)

303-303: LGTM: Consistent spacing refactor.

The removal of pr-2 from the input container and the switch to mx-2 gap-3 on the send-request container standardizes the spacing approach using gap-based layout instead of individual margins.

Also applies to: 318-318

packages/bruno-app/src/components/RequestPane/QueryUrl/index.js (1)

378-378: LGTM: Streamlined spacing with gap utilities.

The refactor removes padding/margin utilities (pr-2, mr-3) and adopts mx-2 gap-3 for consistent spacing. Since gap-3 handles spacing between flex children, the individual margins on infotip elements are no longer needed.

Also applies to: 396-396, 399-399, 409-409

packages/bruno-app/src/components/RequestPane/WsQueryUrl/index.js (1)

126-126: LGTM: Unified spacing approach.

The refactor removes redundant padding/margin classes and centralizes spacing control using gap-3 mx-3 on the parent container. The connection-controls now rely on parent gap spacing rather than their own margin/gap values, which simplifies the layout.

Also applies to: 141-141, 143-143, 162-162, 176-176


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

CLI Test Results

  1 files  ±0  140 suites  ±0   47s ⏱️ -13s
235 tests ±0  235 ✅ +1  0 💤 ±0  0 ❌  - 1 
301 runs  ±0  300 ✅ +1  1 💤 ±0  0 ❌  - 1 

Results for commit 03873af. ± Comparison against base commit dcbf38b.

@bijin-bruno bijin-bruno merged commit c837141 into main Jan 7, 2026
9 checks passed
@bijin-bruno bijin-bruno deleted the fix/urlbar-alignment-patch-1 branch January 7, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant