fix: timestamp tooltip message#6688
Conversation
WalkthroughAdds time-based dynamic variable support by exporting a Changes
Sequence Diagram(s)(Skipped — changes are localized UI/validation logic and tests, not a multi-component sequential flow requiring visualization.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/bruno-common/src/utils/faker-functions.ts (1)
3-3: LGTM! Consider adding a clarifying comment.The
timeBasedDynamicVarsSet correctly identifiestimestampandisoTimestampas the variables that return the current time and thus change on every evaluation. The distinction from other date-generating functions (likerandomDateFuture,randomDatePast) is valid since those return faker-generated random dates rather than the current time.Optional: Add JSDoc comment for clarity
Consider adding a brief comment to explain the distinction for future maintainers:
+/** + * Dynamic variables that return the current time and change on every evaluation. + * Other date functions (randomDateFuture, randomDatePast, etc.) return static faker-generated values. + */ export const timeBasedDynamicVars = new Set(['timestamp', 'isoTimestamp']);
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/bruno-common/src/utils/faker-functions.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (CODING_STANDARDS.md)
**/*.{js,jsx,ts,tsx}: Use 2 spaces for indentation. No tabs, just spaces
Stick to single quotes for strings. For JSX/TSX attributes, use double quotes (e.g., )
Always add semicolons at the end of statements
No trailing commas
Always use parentheses around parameters in arrow functions, even for single params
For multiline constructs, put opening braces on the same line, and ensure consistency. Minimum 2 elements for multiline
No newlines inside function parentheses
Space before and after the arrow in arrow functions.() => {}is good
No space between function name and parentheses.func()notfunc ()
Semicolons go at the end of the line, not on a new line
Names for functions need to be concise and descriptive
Add in JSDoc comments to add more details to the abstractions if needed
Add in meaningful comments instead of obvious ones where complex code flow is explained properly
Files:
packages/bruno-common/src/utils/faker-functions.ts
🧬 Code graph analysis (1)
packages/bruno-common/src/utils/faker-functions.ts (1)
packages/bruno-common/src/index.ts (1)
timeBasedDynamicVars(1-1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: SSL Tests - Windows
- GitHub Check: SSL Tests - Linux
- GitHub Check: SSL Tests - macOS
- GitHub Check: Playwright E2E Tests
- GitHub Check: Unit Tests
- GitHub Check: CLI Tests
Description
JIRA
Fixed misleading tooltip message for
$timestampand$isoTimestampdynamic variablesContribution Checklist:
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.