Skip to content

fix: request and response pane height#6294

Merged
sid-bruno merged 1 commit intousebruno:mainfrom
pooja-bruno:fix/request-and-response-pane-height
Dec 4, 2025
Merged

fix: request and response pane height#6294
sid-bruno merged 1 commit intousebruno:mainfrom
pooja-bruno:fix/request-and-response-pane-height

Conversation

@pooja-bruno
Copy link
Collaborator

@pooja-bruno pooja-bruno commented Dec 3, 2025 •
edited by coderabbitai bot
Loading

Description

JIRA

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.
image

Summary by CodeRabbit

  • Improvements
    • Increased the minimum height allocation for the top pane to improve layout visibility and usability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025 •
edited
Loading

Walkthrough

The minimum top pane height constant was increased from 150 to 380 pixels in the tab pane boundaries hook. Additionally, the top calculation now includes a fallback to MIN_TOP_PANE_HEIGHT when focusedTab?.requestPaneHeight is undefined or null.

Changes

Cohort / File(s) Summary
Pane Boundary Configuration
packages/bruno-app/src/hooks/useTabPaneBoundaries/index.js		 Increased MIN_TOP_PANE_HEIGHT constant from 150 to 380; added fallback logic to use minimum height when focused tab's requested pane height is unavailable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the new minimum height (380) aligns with UI/UX requirements and doesn't break responsive layouts on smaller screens
  • Confirm the fallback logic handles edge cases appropriately (undefined, null, NaN values)

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • naman-bruno
  • bijin-bruno

Poem

📐 The panes grow taller, reaching high,
From 150 to 380 pixels in the sky,
With safety nets when heights are unknown,
Your UI boundaries are firmly sown. 🎨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adjusting pane height logic for the request and response panes.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)

✅ Unit Test PR creation complete.

  • Create PR with unit tests
  • Commit unit tests in branch fix/request-and-response-pane-height
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@usebruno usebruno deleted a comment from coderabbitai bot Dec 3, 2025
@usebruno usebruno deleted a comment from coderabbitai bot Dec 3, 2025
@sid-bruno sid-bruno merged commit 72ce6ca into usebruno:main Dec 4, 2025
8 checks passed
bijin-bruno pushed a commit that referenced this pull request Dec 4, 2025
@pooja-bruno @bijin-bruno
fix: request and response pane height (#6294)
d75f673
@coderabbitai coderabbitai bot mentioned this pull request Dec 11, 2025
Merged
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 18, 2025
Closed
6 tasks
@coderabbitai coderabbitai bot mentioned this pull request Feb 19, 2026
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sid-bruno sid-bruno sid-bruno approved these changes

@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner

@bijin-bruno bijin-bruno Awaiting requested review from bijin-bruno bijin-bruno is a code owner

@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner

@naman-bruno naman-bruno Awaiting requested review from naman-bruno naman-bruno is a code owner

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pooja-bruno @sid-bruno