Skip to content

fix: stringify rawValue in brunoVarInfo#6281

Merged
bijin-bruno merged 1 commit intousebruno:mainfrom
Pragadesh-45:fix/6525
Dec 3, 2025
Merged

fix: stringify rawValue in brunoVarInfo#6281
bijin-bruno merged 1 commit intousebruno:mainfrom
Pragadesh-45:fix/6525

Conversation

@Pragadesh-45
Copy link
Contributor

@Pragadesh-45 Pragadesh-45 commented Dec 3, 2025 •
edited by coderabbitai bot
Loading

fixes: #6265

Description (CodeRabbit)

  • Bug Fixes
    • Improved variable value handling in the editor. Numeric and non-string values are now properly converted to strings for consistent and reliable display, preventing potential rendering errors.

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where non-string values in the code editor could cause display problems, ensuring proper compatibility with the editor.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025 •
edited
Loading

Walkthrough

Changed CodeMirror tooltip handling to always convert environment variable values to strings before passing them to the editor, using an explicit null check and String() conversion to avoid non-string values being forwarded.

Changes

Cohort / File(s) Summary
CodeMirror Variable Info Fix
packages/bruno-app/src/utils/codemirror/brunoVarInfo.js		 Replace `scopeInfo.value

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-file, small, well-scoped type coercion change.
  • Review focus: correct null check, no unintended side effects, and consistency with surrounding code.

Suggested reviewers

  • lohit-bruno
  • helloanoop
  • bijin-bruno

Poem

A hover once tripped on a number's song,
Now every value sings where it belongs,
String-wrapped and steady, the tooltip hums,
Quietly fixing the little bums,
Hover on—no more wrong. ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the specific fix: stringifying rawValue in brunoVarInfo, which matches the core change in the changeset.
Linked Issues check ✅ Passed The PR addresses issue #6265 by ensuring CodeMirror receives a string value, preventing the crash when hovering over environment variables in JSON bodies.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to the brunoVarInfo.js file, converting rawValue to string as required to fix the hover crash issue with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 732e9ab and 07c6b45.

📒 Files selected for processing (1)
  • packages/bruno-app/src/utils/codemirror/brunoVarInfo.js (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/bruno-app/src/utils/codemirror/brunoVarInfo.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: CLI Tests
  • GitHub Check: Playwright E2E Tests
  • GitHub Check: Unit Tests
  • GitHub Check: SSL Tests - Windows
  • GitHub Check: SSL Tests - macOS
  • GitHub Check: SSL Tests - Linux

Comment @coderabbitai help to get the list of available commands and usage tips.

@bijin-bruno bijin-bruno merged commit 38ba53b into usebruno:main Dec 3, 2025
8 checks passed
@sreelakshmi-bruno sreelakshmi-bruno mentioned this pull request Dec 4, 2025
Closed
5 tasks
bijin-bruno pushed a commit that referenced this pull request Dec 4, 2025
@Pragadesh-45 @bijin-bruno
fix: stringify rawValue in brunoVarInfo (#6281)
c8fc7cb
This was referenced Dec 4, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 17, 2025
Open
@coderabbitai coderabbitai bot mentioned this pull request Feb 10, 2026
Closed
5 tasks
@coderabbitai coderabbitai bot mentioned this pull request Mar 4, 2026
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bijin-bruno bijin-bruno bijin-bruno approved these changes

@helloanoop helloanoop Awaiting requested review from helloanoop helloanoop is a code owner

@lohit-bruno lohit-bruno Awaiting requested review from lohit-bruno lohit-bruno is a code owner

@naman-bruno naman-bruno Awaiting requested review from naman-bruno naman-bruno is a code owner

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hovering over envVariable in JSON request body triggers Oops! Something went wrong screen

2 participants

@Pragadesh-45 @bijin-bruno