added copy button to copy response#6131
Merged
sid-bruno merged 5 commits intousebruno:feat/copy-response-to-clipboard-5409from Dec 2, 2025
Merged
Conversation
…d-5409' into feat/add-copy-button-for-response
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
sid-bruno
approved these changes
Dec 2, 2025
4c11726
into
usebruno:feat/copy-response-to-clipboard-5409
2 checks passed
sid-bruno
added a commit
that referenced
this pull request
Dec 2, 2025
* added copy button to copy response * add: response action component * fix: lint error * add: playwright test --------- Co-authored-by: Shashank Shekhar <48152748+sha5-git@users.noreply.github.com> Co-authored-by: Sid <siddharth@usebruno.com>
sid-bruno
added a commit
that referenced
this pull request
Dec 2, 2025
* added copy button to copy response * add: response action component * fix: lint error * add: playwright test --------- Co-authored-by: Shashank Shekhar <48152748+sha5-git@users.noreply.github.com> Co-authored-by: Sid <siddharth@usebruno.com>
sid-bruno
added a commit
that referenced
this pull request
Dec 2, 2025
* added copy button to copy response * add: response action component * fix: lint error * add: playwright test --------- Co-authored-by: Shashank Shekhar <48152748+sha5-git@users.noreply.github.com> Co-authored-by: Sid <siddharth@usebruno.com>
sid-bruno
added a commit
that referenced
this pull request
Dec 2, 2025
* added copy button to copy response * add: response action component * fix: lint error * add: playwright test --------- Co-authored-by: Shashank Shekhar <48152748+sha5-git@users.noreply.github.com> Co-authored-by: Sid <siddharth@usebruno.com>
helloanoop
reviewed
Dec 2, 2025
|
|
||
| const StyledWrapper = styled.div` | ||
| button { | ||
| color: var(--color-tab-inactive); |
Contributor
There was a problem hiding this comment.
@pooja-bruno @sid-bruno We should not be using css vars. We should use theme props.
helloanoop
reviewed
Dec 2, 2025
| await copyButton.click(); | ||
|
|
||
| // Verify toast notification appears | ||
| await expect(page.getByText('Response copied to clipboard')).toBeVisible(); |
Contributor
There was a problem hiding this comment.
A better check would be to confirm that the clipboard was indeed populated
const clipboardText = await page.evaluate(() => navigator.clipboard.readText());
expect(clipboardText).toBe('Expected copied value');
naman-bruno
pushed a commit
to naman-bruno/bruno
that referenced
this pull request
Dec 3, 2025
* added copy button to copy response * add: response action component * fix: lint error * add: playwright test --------- Co-authored-by: Shashank Shekhar <48152748+sha5-git@users.noreply.github.com> Co-authored-by: Sid <siddharth@usebruno.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
JIRA
Issue: #5408
Contribution Checklist:
Screen.Recording.2025-11-18.at.4.42.57.PM.mov