Skip to content

feat: apply modified dataBuffer to the response#6023

Merged
sid-bruno merged 3 commits intousebruno:mainfrom
Pragadesh-45:feat/apply-modified-databuffer-on-response-data
Jan 12, 2026
Merged

feat: apply modified dataBuffer to the response#6023
sid-bruno merged 3 commits intousebruno:mainfrom
Pragadesh-45:feat/apply-modified-databuffer-on-response-data

Conversation

@Pragadesh-45
Copy link
Contributor

@Pragadesh-45 Pragadesh-45 commented Nov 7, 2025

fixes: #6003, #6133

Description

This PR implements a feature that applies the dataBuffer to the final return, ensuring that the response edited with res.setBody is actually set in the response

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Before:
image

After:
image

@Pragadesh-45 Pragadesh-45 force-pushed the feat/apply-modified-databuffer-on-response-data branch from 4c16f09 to 31ae7be Compare November 25, 2025 12:18
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 25, 2025
@Pragadesh-45 Pragadesh-45 force-pushed the feat/apply-modified-databuffer-on-response-data branch from 31ae7be to 4589736 Compare November 25, 2025 12:20
@pull-request-size pull-request-size bot added size/S and removed size/M labels Nov 25, 2025
Copy link
Collaborator

@bijin-bruno bijin-bruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the failed tests

@Pragadesh-45 Pragadesh-45 force-pushed the feat/apply-modified-databuffer-on-response-data branch from 4589736 to 71e33b0 Compare November 26, 2025 07:36
@helloanoop
Copy link
Contributor

@Pragadesh-45 Tests please

@gkissel
Copy link

gkissel commented Dec 4, 2025

Any Update on this?

@retorquere
Copy link

which version do I have to downgrade to to restore the old behavior? This is a real problem for me.

@sid-bruno
Copy link
Collaborator

@shubh-bruno , validate the PR, check if it needs any additional changes and let me know

@shubh-bruno shubh-bruno mentioned this pull request Jan 9, 2026
5 tasks
@sid-bruno sid-bruno merged commit 734ee16 into usebruno:main Jan 12, 2026
7 checks passed
FraCata00 pushed a commit to FraCata00/bruno that referenced this pull request Feb 9, 2026
* feat: apply modified dataBuffer to the response

* fix: ensure dataBuffer regeneration only occurs when res.setBody() is called

* refactor: update dataBuffer handling in BrunoResponse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP 204 response doesn't allow res.setBody()

6 participants