feat(revive): include pallet-revive #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cmichi
approved these changes
Nov 21, 2024
cmichi
left a comment
There was a problem hiding this comment.
At first I decided to just substitute the pallets, but it seemed more useful if the runtime will host both pallets for now.
I agree, let's leave both in for now.
cmichi
pushed a commit
that referenced
this pull request
Nov 28, 2024
* feat(revive): include initial version of pallet-revive * chore(contracts-node): bring back pallet-contracts
smiasojed
pushed a commit
to paritytech/substrate-contracts-node
that referenced
this pull request
Nov 29, 2024
…238) Credit for the main work has to go to @al3mart with use-ink#1 and use-ink#2. ## Synced with `polkadot-stable2409` >This PR uplifts versions and sync `substrate-contracts-node` with SDK version `polkadot-stable2409`. >Aside from the application of the different commits coming with the version update, the collator has been change from using a basic collator to lookahead. >Crate versions have also been bumped to 0.42.0. ## Added `pallet-revive` > Inclusion of `pallet-revive` along with `pallet-contracts`. Such that the runtimes will feature both VMs. --------- Co-authored-by: Alejandro Martinez Andres <11448715+al3mart@users.noreply.github.com>
isaiah86z
added a commit
to isaiah86z/substrate-contracts-node
that referenced
this pull request
Sep 7, 2025
…#238) Credit for the main work has to go to @al3mart with use-ink/substrate-contracts-node#1 and use-ink/substrate-contracts-node#2. ## Synced with `polkadot-stable2409` >This PR uplifts versions and sync `substrate-contracts-node` with SDK version `polkadot-stable2409`. >Aside from the application of the different commits coming with the version update, the collator has been change from using a basic collator to lookahead. >Crate versions have also been bumped to 0.42.0. ## Added `pallet-revive` > Inclusion of `pallet-revive` along with `pallet-contracts`. Such that the runtimes will feature both VMs. --------- Co-authored-by: Alejandro Martinez Andres <11448715+al3mart@users.noreply.github.com>
maxallen687
added a commit
to maxallen687/substrate
that referenced
this pull request
Jan 16, 2026
…#238) Credit for the main work has to go to @al3mart with use-ink/substrate-contracts-node#1 and use-ink/substrate-contracts-node#2. ## Synced with `polkadot-stable2409` >This PR uplifts versions and sync `substrate-contracts-node` with SDK version `polkadot-stable2409`. >Aside from the application of the different commits coming with the version update, the collator has been change from using a basic collator to lookahead. >Crate versions have also been bumped to 0.42.0. ## Added `pallet-revive` > Inclusion of `pallet-revive` along with `pallet-contracts`. Such that the runtimes will feature both VMs. --------- Co-authored-by: Alejandro Martinez Andres <11448715+al3mart@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inclusion of
pallet-revivealong withpallet-contracts. Such that the runtimes will feature both VMs. At first I decided to just substitute the pallets, but it seemed more useful if the runtime will host both pallets for now.The version of
pallet-revivematches crate version released for sdkstable2409, which unfortunately lacks some features in comparison with more actual versions of the pallet, yet to be released. For instance stateful address mapping.An approach to include a more up to date version of the pallet could be a local fork until a new version is released.
Happy to introduce the changes if necessary.