Fix(core): Type definition for GraphQLRequestParams#3807
Merged
JoviDeCroock merged 2 commits intourql-graphql:mainfrom Aug 9, 2025
Merged
Fix(core): Type definition for GraphQLRequestParams#3807JoviDeCroock merged 2 commits intourql-graphql:mainfrom
GraphQLRequestParams#3807JoviDeCroock merged 2 commits intourql-graphql:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6327e10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Julien Hauseux <julien.hauseux@gmail.com>
966f8d6 to
5a94c5e
Compare
Contributor
Author
|
Just added a changeset: In my opinion this should be merely a minor bump. |
JoviDeCroock
approved these changes
Aug 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation makes the field
variablesoptional if and only if at least one field ofVariablesisvoid | null.Instead, it should make the field
variablesoptional if and only if all the fields ofVariablesare either optional or can benull | void:You can check both behaviors here.
In particular, you'll see:
Set of changes
Just fixed the type definition.
This should not be a breaking change as it only affect typing, although it may cause compilation errors for code that was previously (incorrectly) allowed to omit required variables.