Miscelanous minor changes to the codebase from #475#554
Closed
leogama wants to merge 4 commits intouqfoundation:masterfrom
Closed
Miscelanous minor changes to the codebase from #475#554leogama wants to merge 4 commits intouqfoundation:masterfrom
leogama wants to merge 4 commits intouqfoundation:masterfrom
Conversation
mmckerns
requested changes
Feb 5, 2023
Member
mmckerns
left a comment
There was a problem hiding this comment.
LGTM. I'd approve, but the tests are failing. Ensure the tests pass, and let's pull this.
mmckerns
reviewed
Feb 5, 2023
| # Flags set by dump_module() is dill.session: | ||
| _refimported = False | ||
| _refonfail = False | ||
| _session = False |
Member
There was a problem hiding this comment.
seems _session shouldn't have been deleted -- it's still used in _locate_function and _save_module_dict.
mmckerns
added a commit
that referenced
this pull request
Feb 8, 2023
Member
|
obsoleted by #573 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To remove some of the cruft there.