Skip to content

Conversation

@loispostula
Copy link
Contributor

@loispostula loispostula commented Jan 10, 2026

Allow setting npmrcpath, url, and registrytoken at npm autodiscovery
level. Fields propagate to all generated npm source manifests.

Fix #7478

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/autodiscovery/npm
go test

Additional Information

Checklist

Tradeoff

Potential improvement

   Allow setting npmrcpath, url, and registrytoken at npm autodiscovery
   level. Fields propagate to all generated npm source manifests.

   Fixes #7478
@loispostula loispostula force-pushed the lp/resource-level-spec-ad branch from 5f1b4a9 to 5a4d95a Compare January 10, 2026 10:46
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@olblak olblak merged commit bfff195 into main Jan 11, 2026
5 checks passed
@olblak olblak deleted the lp/resource-level-spec-ad branch January 11, 2026 07:51
@olblak olblak added enhancement New feature or request autodiscovery All things related to the autodiscovery feature resource-npm labels Jan 11, 2026
ErickdelaCruzCas pushed a commit to ErickdelaCruzCas/updatecli that referenced this pull request Jan 13, 2026
Allow setting npmrcpath, url, and registrytoken at npm autodiscovery
   level. Fields propagate to all generated npm source manifests.

   Fixes updatecli#7478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autodiscovery All things related to the autodiscovery feature enhancement New feature or request resource-npm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Propagate resource-level spec from autodiscovery

3 participants