feat: detect auto-debug in the CI#2822
Merged
olblak merged 11 commits intoupdatecli:mainfrom Oct 23, 2024
Merged
Conversation
loispostula
previously requested changes
Oct 18, 2024
Contributor
loispostula
left a comment
There was a problem hiding this comment.
Thanks for the contribution
Co-authored-by: Loïs Postula <lois@postu.la>
olblak
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2805
Test
To test this pull request, you can run the following commands:
make build $ GITHUB_ACTION=foo ACTIONS_RUNNER_DEBUG=true dist/updatecli_darwin_arm64/updatecli diff CI pipeline detected in Debug Mode - hence enabling debug mode +++++++++++ + PREPARE + +++++++++++ ... $ GITHUB_ACTION=foo ACTIONS_RUNNER_DEBUG=false dist/updatecli_darwin_arm64/updatecli diff +++++++++++ + PREPARE + +++++++++++Additional Information
Tradeoff
There is no support for Jenkins, as I cannot recall there is a way to use an env variable to set the debug level for Pipelines. Back in the day, I used https://github.com/elastic/apm-pipeline-library/blob/main/vars/log.groovy, but it was an opinionated approach.
Potential improvement
Support for Jenkins