Skip to content

Conversation

@olblak
Copy link
Member

@olblak olblak commented Aug 29, 2024

Fix #2429

While investigating this issue, I noticed that I wasn't using the recommended way of authenticating on GitLab according
this documentation

This pull request uses a fork of the go-scm library until my fix is merged upstream

Test

To test this pull request, you can run the following commands:
Test manually

Additional Information

Tradeoff

Potential improvement

olblak added 2 commits August 29, 2024 17:06
Signed-off-by: Olblak <me@olblak.com>
Use a fork of the drone/go-scm project until drone/go-scm#322 is
merged and available.

More information on updatecli#2429
@olblak olblak added bug Something isn't working scm-gitlab labels Aug 29, 2024
@olblak olblak changed the title feat: implement prow autodiscovery fix: gitlab merge requests error Aug 29, 2024
@olblak olblak merged commit 3b64fde into updatecli:main Aug 29, 2024
@olblak olblak deleted the issue-2429 branch August 29, 2024 18:32
olblak added a commit to olblak/updatecli that referenced this pull request Sep 3, 2024
* fix: gitlab token configuration

Signed-off-by: Olblak <me@olblak.com>

* fix: pass gitlab MR parameter via http body

Use a fork of the drone/go-scm project until drone/go-scm#322 is
merged and available.

More information on updatecli#2429

---------

Signed-off-by: Olblak <me@olblak.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working scm-gitlab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gitlab merge requests error

1 participant