Fix: address potential negative value of denom in Pearson correlation calculation#707
Merged
ashvardanian merged 5 commits intounum-cloud:main-devfrom Jan 27, 2026
Merged
Fix: address potential negative value of denom in Pearson correlation calculation#707ashvardanian merged 5 commits intounum-cloud:main-devfrom
ashvardanian merged 5 commits intounum-cloud:main-devfrom
Conversation
### Minor - Add: Python 3.14 support (unum-cloud#693) (43ee8b7)
Contributor
|
Thank you, @huahaiy! |
ashvardanian
pushed a commit
that referenced
this pull request
Feb 16, 2026
### Minor - Add: GetHandle and GetConfig to give access to the C handle in Golang (#705) (dec24b8) ### Patch - Make: Bump SimSIMD (2be3bbb) - Fix: `mmap` flags for FreeBSD (#711) (3ad2485) - Fix: Compilation errors in Qt environment (#706) (20cb742) - Fix: Negative denominator in Pearson correlation (#707) (34d5b8c) - Docs: Fix broken links (#708) (453290d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For small dimensions, e.g. 2, it is possible to get negative value due to numerical issues in calculating
result_t denom = (dim * a_sq_sum - a_sum * a_sum) * (dim * b_sq_sum - b_sum * b_sum);Then
std:sqrt(demon)will returnNaN, leading to infinite loop in search algorithm, e.g.(-candidate.distance) > radiuswill always be false, leading to system hang.