Feature: simplified chinese translation#177
Merged
untra merged 2 commits intountra:masterfrom Jun 8, 2023
Merged
Conversation
untra
reviewed
Jun 7, 2023
| nl: Hallo! | ||
| he: "שלום!" | ||
| ko: 안녕하세요! | ||
| zh-CN: 你好! |
Owner
There was a problem hiding this comment.
Note: I use
zh-CNas the corresponding i18n code but notzh
That's totally fine and correct here. Many other countries will use a country-specific designation as part of their browser configuration (for example Portuguese in portugal and brazil are considered different as well and those countries will favor pt-PT or pt-BR).
worth calling out the in readme for users of these language codes.
untra
approved these changes
Jun 8, 2023
untra
added a commit
that referenced
this pull request
Jun 9, 2023
…lation Feature: simplified chinese translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔤 Polyglot PR
The website fully supports Simplified Chinese now.
Note: I use
zh-CNas the corresponding i18n code but notzh. "Chinese" is actually a written/script system rather than a single language. When we talk about "Chinese" as a language without any specific limitations, it usually refers to Mandarin Chinese, which is the official language of the People's Republic of China(mainland China), the Republic of Singapore, and Taiwan. According to i18n locale codes, Mandarin Chinese language are divided into several subcategories for these different political entities. In a similar way to American English and British English, mainland China Mandarin (written in Simplified Chinese) and Taiwanese Mandarin (written in Traditional Chinese) are the two primary variants of Mandarin Chinese, and there are slight differences in vocabulary between them. Therefore, I cannot give a perfectly accuratezh-TWtranslation by simply transforming the simplified Chinese characters into traditional ones. As a native Mainlander, I think my personal translation can only represent people who originate from mainland China.Type of change
Checklists