Support image_url with the url field#57
Merged
danielhanchen merged 2 commits intoMar 6, 2025
Merged
Conversation
|
dont see any harm in that .. lgtm - if anything it offers more flexibility how the dataset is constructed, uncertain if daniel /mike need a cla for that as its not apache2 |
Member
|
Yep this looks good! Thanks! |
Contributor
Author
|
@danielhanchen Thank you very much for the merge! This support will help a lot for some datasets! |
danielhanchen
added a commit
that referenced
this pull request
Mar 6, 2025
* Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update compiler.py * Update compiler.py * Fix requires grad * Update peft_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update peft_utils.py * Update peft_utils.py * Update peft_utils.py * Update peft_utils.py * _get_dtype * Update utils.py * better attribution * Update compiler.py * Last layer GC * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Saving, llama.cpp * Update llama_cpp.py * Update llama_cpp.py * Add error handling for forward method in patch_gradient_accumulation (#32) * Update peft_utils.py * Update peft_utils.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update __init__.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update llama_cpp.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update saving_utils.py * Update __init__.py * Create vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Licensing, bug fixes * Update patching_utils.py * Update vllm_utils.py * Update __init__.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * rotary * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * load lora from tensors * 0.7.1 lora request * Update vllm_lora_request.py * Update vllm_lora_request.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update compiler.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update __init__.py * Create logging_utils.py * Update logging_utils.py * Update logging_utils.py * Update logging_utils.py * Update logging_utils.py * Update vllm_utils.py * fix_zero_training_loss * Update dataset_utils.py * Update training_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_lora_worker_manager.py * Update vllm_lora_worker_manager.py * Update vllm_utils.py * Update vllm_lora_worker_manager.py * Update vllm_lora_worker_manager.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update __init__.py * Create rl_replacements.py * Update __init__.py * Fixes * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update saving_utils.py * Update saving_utils.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update __init__.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update pyproject.toml * Update rl_replacements.py * Update rl_replacements.py * Update __init__.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update __init__.py * compiling issues * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * SFT dataset prepare * Update pyproject.toml * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update compiler.py * Update __init__.py * Update compiler.py * Update compiler.py * Update compiler.py * Update __init__.py * Update compiler.py * Update compiler.py * Support `image_url` with the `url` field (#57) * Support `image_url` with the `url` field * Update vision_utils.py --------- Co-authored-by: Daniel Han <danielhanchen@gmail.com> * Update compiler.py * Update compiler.py * Update compiler.py * Update utils.py * Update compiler.py --------- Co-authored-by: Edd <68678137+Erland366@users.noreply.github.com> Co-authored-by: Mehmet Oguz Derin <mehmetoguzderin@mehmetoguzderin.com>
danielhanchen
added a commit
that referenced
this pull request
Mar 8, 2025
* better attribution * Update compiler.py * Last layer GC * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Saving, llama.cpp * Update llama_cpp.py * Update llama_cpp.py * Add error handling for forward method in patch_gradient_accumulation (#32) * Update peft_utils.py * Update peft_utils.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update __init__.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update llama_cpp.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update saving_utils.py * Update __init__.py * Create vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Licensing, bug fixes * Update patching_utils.py * Update vllm_utils.py * Update __init__.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * rotary * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * load lora from tensors * 0.7.1 lora request * Update vllm_lora_request.py * Update vllm_lora_request.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update compiler.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update __init__.py * Create logging_utils.py * Update logging_utils.py * Update logging_utils.py * Update logging_utils.py * Update logging_utils.py * Update vllm_utils.py * fix_zero_training_loss * Update dataset_utils.py * Update training_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_lora_worker_manager.py * Update vllm_lora_worker_manager.py * Update vllm_utils.py * Update vllm_lora_worker_manager.py * Update vllm_lora_worker_manager.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update __init__.py * Create rl_replacements.py * Update __init__.py * Fixes * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update saving_utils.py * Update saving_utils.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update __init__.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update pyproject.toml * Update rl_replacements.py * Update rl_replacements.py * Update __init__.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update __init__.py * compiling issues * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * SFT dataset prepare * Update pyproject.toml * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update compiler.py * Update __init__.py * Update compiler.py * Update compiler.py * Update compiler.py * Update __init__.py * Update compiler.py * Update compiler.py * Support `image_url` with the `url` field (#57) * Support `image_url` with the `url` field * Update vision_utils.py --------- Co-authored-by: Daniel Han <danielhanchen@gmail.com> * Update compiler.py * Update compiler.py * Update compiler.py * Update utils.py * Update compiler.py * Update compiler.py * Fix compiling * Update patching_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * distributed_function * Update compiler.py * Update compiler.py * distributed * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py --------- Co-authored-by: Edd <68678137+Erland366@users.noreply.github.com> Co-authored-by: Mehmet Oguz Derin <mehmetoguzderin@mehmetoguzderin.com>
danielhanchen
added a commit
that referenced
this pull request
Mar 12, 2025
* Update logging_utils.py * Update logging_utils.py * Update logging_utils.py * Update logging_utils.py * Update vllm_utils.py * fix_zero_training_loss * Update dataset_utils.py * Update training_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_lora_worker_manager.py * Update vllm_lora_worker_manager.py * Update vllm_utils.py * Update vllm_lora_worker_manager.py * Update vllm_lora_worker_manager.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update __init__.py * Create rl_replacements.py * Update __init__.py * Fixes * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update saving_utils.py * Update saving_utils.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update __init__.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update pyproject.toml * Update rl_replacements.py * Update rl_replacements.py * Update __init__.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update __init__.py * compiling issues * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * SFT dataset prepare * Update pyproject.toml * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update compiler.py * Update __init__.py * Update compiler.py * Update compiler.py * Update compiler.py * Update __init__.py * Update compiler.py * Update compiler.py * Support `image_url` with the `url` field (#57) * Support `image_url` with the `url` field * Update vision_utils.py --------- Co-authored-by: Daniel Han <danielhanchen@gmail.com> * Update compiler.py * Update compiler.py * Update compiler.py * Update utils.py * Update compiler.py * Update compiler.py * Fix compiling * Update patching_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * distributed_function * Update compiler.py * Update compiler.py * distributed * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Prepare for training * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update pyproject.toml * compiler * Update loss_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * debugging * remove debugging * num items in batch * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * logs * Update patching_utils.py * VLM attention mask * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Recheck * Update compiler.py * Update patching_utils.py * Update patching_utils.py * Update patching_utils.py * Update patching_utils.py * Update compiler.py * Update patching_utils.py * suppress errors * Update compiler.py * Update patching_utils.py * Update compiler.py * Update patching_utils.py * Update patching_utils.py * Update patching_utils.py * Update peft_utils.py * Update compiler.py * Update loss_utils.py * Update loss_utils.py --------- Co-authored-by: Mehmet Oguz Derin <mehmetoguzderin@mehmetoguzderin.com>
danielhanchen
added a commit
that referenced
this pull request
Mar 13, 2025
* Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update vllm_utils.py * Update __init__.py * Create rl_replacements.py * Update __init__.py * Fixes * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update saving_utils.py * Update saving_utils.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update __init__.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update pyproject.toml * Update rl_replacements.py * Update rl_replacements.py * Update __init__.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update __init__.py * compiling issues * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * SFT dataset prepare * Update pyproject.toml * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update compiler.py * Update __init__.py * Update compiler.py * Update compiler.py * Update compiler.py * Update __init__.py * Update compiler.py * Update compiler.py * Support `image_url` with the `url` field (#57) * Support `image_url` with the `url` field * Update vision_utils.py --------- Co-authored-by: Daniel Han <danielhanchen@gmail.com> * Update compiler.py * Update compiler.py * Update compiler.py * Update utils.py * Update compiler.py * Update compiler.py * Fix compiling * Update patching_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * distributed_function * Update compiler.py * Update compiler.py * distributed * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Prepare for training * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update pyproject.toml * compiler * Update loss_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * debugging * remove debugging * num items in batch * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * logs * Update patching_utils.py * VLM attention mask * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Recheck * Update compiler.py * Update patching_utils.py * Update patching_utils.py * Update patching_utils.py * Update patching_utils.py * Update compiler.py * Update patching_utils.py * suppress errors * Update compiler.py * Update patching_utils.py * Update compiler.py * Update patching_utils.py * Update patching_utils.py * Update patching_utils.py * Update peft_utils.py * Update compiler.py * Update loss_utils.py * Update loss_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * bug fixes * Update compiler.py * Update compiler.py * Update vision_utils.py * Update compiler.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Bug fixes * Update dataset_utils.py * Update dataset_utils.py * Update dataset_utils.py * Update dataset_utils.py * Update dataset_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update loss_utils.py * Update loss_utils.py --------- Co-authored-by: Mehmet Oguz Derin <mehmetoguzderin@mehmetoguzderin.com>
danielhanchen
added a commit
that referenced
this pull request
Mar 14, 2025
* Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update pyproject.toml * Update rl_replacements.py * Update rl_replacements.py * Update __init__.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update tokenizer_utils.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update gradient_checkpointing.py * Update __init__.py * compiling issues * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * SFT dataset prepare * Update pyproject.toml * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update compiler.py * Update __init__.py * Update compiler.py * Update compiler.py * Update compiler.py * Update __init__.py * Update compiler.py * Update compiler.py * Support `image_url` with the `url` field (#57) * Support `image_url` with the `url` field * Update vision_utils.py --------- Co-authored-by: Daniel Han <danielhanchen@gmail.com> * Update compiler.py * Update compiler.py * Update compiler.py * Update utils.py * Update compiler.py * Update compiler.py * Fix compiling * Update patching_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * distributed_function * Update compiler.py * Update compiler.py * distributed * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Prepare for training * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update training_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update pyproject.toml * compiler * Update loss_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * debugging * remove debugging * num items in batch * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * logs * Update patching_utils.py * VLM attention mask * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Recheck * Update compiler.py * Update patching_utils.py * Update patching_utils.py * Update patching_utils.py * Update patching_utils.py * Update compiler.py * Update patching_utils.py * suppress errors * Update compiler.py * Update patching_utils.py * Update compiler.py * Update patching_utils.py * Update patching_utils.py * Update patching_utils.py * Update peft_utils.py * Update compiler.py * Update loss_utils.py * Update loss_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * bug fixes * Update compiler.py * Update compiler.py * Update vision_utils.py * Update compiler.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Update loss_utils.py * Bug fixes * Update dataset_utils.py * Update dataset_utils.py * Update dataset_utils.py * Update dataset_utils.py * Update dataset_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update loss_utils.py * Update loss_utils.py * gpu_memory_utilization * Update temporary_patches.py * Update vision_utils.py * Update vision_utils.py * Update vision_utils.py * Update vision_utils.py * Update vision_utils.py * Update vision_utils.py * Update vision_utils.py * Update vision_utils.py * train on completions VLMs * Update dataset_utils.py * Update dataset_utils.py * Update dataset_utils.py * Update dataset_utils.py * VLM train only on completions * Update loss_utils.py * Update dataset_utils.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update compiler.py * Update saving_utils.py * Update llama_cpp.py * Update llama_cpp.py * Update saving_utils.py * Update saving_utils.py * Update __init__.py * Update compiler.py * Update loss_utils.py * Update compiler.py * Update loss_utils.py * Update loss_utils.py * Update llama_cpp.py * Update loss_utils.py * Update compiler.py * Update llama_cpp.py * Update compiler.py * Update vllm_utils.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py * Update rl_replacements.py --------- Co-authored-by: Mehmet Oguz Derin <mehmetoguzderin@mehmetoguzderin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you very much for
unslothand the utilities inunsloth-zooas they help a lot.Increasingly, JSONL or otherwise datasets have a
urlfield rather than simply providing animage_urldirectly as a URL (probably due to tutorials related to OpenAI API) for vision. This PR minimally changes the type annotation and the code to support whenimage_urlis a dictionary rather than a URL string.I tested this with various data, including WebP images encoded as base64.
Reference tutorial with many such examples: https://platform.openai.com/docs/guides/vision
Thank you for your consideration! If there are any changes that would benefit from adjustment, please let me know, and I can update the PR. Kind regards. - Oguz