Clarify NotImplementedError for fast_inference with full_finetuning#3768
Conversation
Summary of ChangesHello @Fizza-Mukhtar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the user experience by providing a more informative and actionable error message within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly improves the error message for an unsupported configuration, making it much clearer for users by explaining the reason and providing actionable workarounds. The change is a great enhancement to user experience. I've included one suggestion to further refine the string formatting for better readability and to remove an unnecessary blank line.
| raise NotImplementedError( | ||
| f"Unsloth: `fast_inference = True` does not yet support `full_finetuning = True`.\n" | ||
| f"Use LoRA rank `r = {max_lora_rank}` as the closest replacement for full finetuning with Unsloth for RL." | ||
| f"`fast_inference=True` cannot be used together with `full_finetuning=True`.\n" | ||
| f"Reason: fast_inference is optimized for inference-only workflows and " | ||
| f"does not currently support full fine-tuning.\n" | ||
| f"Workaround: disable fast_inference, or use parameter-efficient fine-tuning " | ||
| f"(e.g. LoRA with rank r={max_lora_rank})." | ||
| ) | ||
|
|
There was a problem hiding this comment.
The improved error message is great for user experience. For better readability and to adhere to standard Python conventions, you can simplify the string formatting. Using implicit string concatenation and removing f-string prefixes from lines without variables makes the code cleaner. This change also removes the extra blank line after the raise statement.
| raise NotImplementedError( | |
| f"Unsloth: `fast_inference = True` does not yet support `full_finetuning = True`.\n" | |
| f"Use LoRA rank `r = {max_lora_rank}` as the closest replacement for full finetuning with Unsloth for RL." | |
| f"`fast_inference=True` cannot be used together with `full_finetuning=True`.\n" | |
| f"Reason: fast_inference is optimized for inference-only workflows and " | |
| f"does not currently support full fine-tuning.\n" | |
| f"Workaround: disable fast_inference, or use parameter-efficient fine-tuning " | |
| f"(e.g. LoRA with rank r={max_lora_rank})." | |
| ) | |
| raise NotImplementedError( | |
| "`fast_inference=True` cannot be used together with `full_finetuning=True`.\n" | |
| "Reason: fast_inference is optimized for inference-only workflows and " | |
| "does not currently support full fine-tuning.\n" | |
| "Workaround: disable fast_inference, or use parameter-efficient fine-tuning " | |
| f"(e.g. LoRA with rank r={max_lora_rank})." | |
| ) |
|
This is a fair change - thanks for this! |
…nslothai#3768) * Improve error message for fast_inference and full_finetuning * Refine error message string formatting * Update unsloth/models/vision.py --------- Co-authored-by: Daniel Han <danielhanchen@gmail.com>
This PR improves the error message raised when
fast_inference=True is used together with full_finetuning=True.
The updated message explains why the combination is unsupported
and suggests practical workarounds (disabling fast_inference or using LoRA).
No behavior changes are introduced.
Closes #3577