Skip to content

chore: bump pnp v0.9.3#91

Merged
JounQin merged 1 commit intomainfrom
chore/bump
Apr 23, 2025
Merged

chore: bump pnp v0.9.3#91
JounQin merged 1 commit intomainfrom
chore/bump

Conversation

@JounQin
Copy link
Member

@JounQin JounQin commented Apr 23, 2025

close #28

Important

Bump pnp to v0.9.3 and update pnpm version in package.json.

  • Dependencies:
    • Bump pnp version from 0.9.1 to 0.9.3 in Cargo.toml and Cargo.lock.
    • Update packageManager in package.json from pnpm@10.8.1 to pnpm@10.9.0.
  • Misc:
    • Simplify repository and funding fields in package.json to single-line format.

This description was created by Ellipsis for 23b37af. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Chores
    • Updated the optional dependency pnp to version 0.9.3.
    • Simplified the format of the repository and funding fields in the project metadata.
    • Updated the package manager version to pnpm@10.9.0.

@JounQin JounQin requested a review from Copilot April 23, 2025 13:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the version of the "pnp" dependency in Cargo.toml from 0.9.1 to 0.9.3.

  • Bumped "pnp" version to 0.9.3 in Cargo.toml
Files not reviewed (2)
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported

@coderabbitai
Copy link

coderabbitai bot commented Apr 23, 2025

Walkthrough

This update modifies configuration files for both Rust and JavaScript/Node.js projects. In the Rust project's Cargo.toml, the optional dependency pnp is updated from version 0.9.1 to 0.9.3. In the package.json file, the formatting of the repository and funding fields is simplified from object to string notation, and the packageManager version is incremented from pnpm@10.8.1 to pnpm@10.9.0. No changes were made to code, scripts, or public entity declarations.

Changes

File(s) Change Summary
Cargo.toml Updated optional dependency pnp version from 0.9.1 to 0.9.3.
package.json Simplified repository and funding fields to string format; updated packageManager version.

Poem

In the garden of configs, a gentle breeze,
Updates to versions put the mind at ease.
Strings now replace objects, so tidy and neat,
With pnpm hopping forward on nimble feet.
Rust and Node together, their settings aligned,
A rabbit’s delight—such changes combined! 🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a863a07 and 23b37af.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • package.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Benchmark
  • GitHub Check: Test (windows-latest)
🔇 Additional comments (3)
Cargo.toml (1)

80-80:

Details

✅ Verification successful

Confirm and approve the pnp version bump
The optional Rust dependency pnp was updated from 0.9.1 to 0.9.3, aligning with the coordinated tooling bump.
Please verify that version 0.9.3 is published on crates.io and contains no unexpected breaking changes.

Run this script to check crates.io for the new version:


🏁 Script executed:

#!/bin/bash
curl -s https://crates.io/api/v1/crates/pnp | jq '.versions[].num' | grep -x "0.9.3"

Length of output: 84


🏁 Script executed:

#!/bin/bash
# Check available pnp versions without quotes
curl -s https://crates.io/api/v1/crates/pnp | jq -r '.versions[].num' | grep -x "0.9.3"

# Verify that version 0.9.3 exists by checking its dedicated endpoint status code
status=$(curl -s -o /dev/null -w "%{http_code}" "https://crates.io/api/v1/crates/pnp/0.9.3")
echo "HTTP status for pnp/0.9.3: $status"

Length of output: 261


pnp v0.9.3 is published on crates.io
HTTP status 200 confirms that version 0.9.3 is available, matching the Cargo.toml bump. Approving these changes.

package.json (2)

21-21:

Details

✅ Verification successful

Upgrade packageManager to pnpm@10.9.0
Bumping the packageManager version keeps tooling in sync with the Rust pnp bump. Confirm your local setup is updated accordingly.

Verify with:


🏁 Script executed:

pnpm -v

Length of output: 16


packageManager version is up‑to‑date

Confirmed local pnpm version (pnpm -v → 10.9.0) matches the updated packageManager field. All set!


5-6:

Details

✅ Verification successful

Simplify repository and funding fields
Switching from object notation to a plain string is compliant with the npm spec and reduces verbosity. Ensure downstream consumers (e.g., npm view, documentation generators) still parse these fields correctly.

Verify via:


🏁 Script executed:

npm pkg get repository funding

Length of output: 152


Verified: Simplified repository and funding fields parse correctly
The npm pkg get repository funding output confirms both fields are recognized as strings by npm. No further changes needed.

  • package.json (lines 5–6)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (a863a07) to head (23b37af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files          13       13           
  Lines        2856     2856           
=======================================
  Hits         2667     2667           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 23b37af in 1 minute and 17 seconds. Click for details.
  • Reviewed 142 lines of code in 3 files
  • Skipped 1 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Cargo.lock:780
  • Draft comment:
    Bump of pnp from 0.9.1 to 0.9.3 adds extra dependencies. Verify that these new deps (clean-path, path-slash, radix_trie) are expected in the new release.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is related to a dependency change, specifically a version bump of pnp. It asks the author to verify if the new dependencies are expected. This falls under the rule of not commenting on dependency changes or asking the author to verify intentions. Therefore, this comment should be removed.
2. Cargo.toml:77
  • Draft comment:
    Update pnp dependency version in Cargo.toml to 0.9.3 to match Cargo.lock.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
3. package.json:21
  • Draft comment:
    Upgrade pnpm version from 10.8.1 to 10.9.0; ensure this version is compatible with your tooling.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is about a dependency change, specifically upgrading the pnpm version. The comment suggests ensuring compatibility, which is against the rules for comments. The comment does not provide a specific suggestion or point out a specific issue with the change.
4. Cargo.lock:781
  • Draft comment:
    Bump 'pnp' to 0.9.3: note new deps (clean-path, path-slash, radix_trie) and the shift in thiserror version. Confirm compatibility with downstream consumers.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
5. Cargo.toml:77
  • Draft comment:
    Update pnp dependency from 0.9.1 to 0.9.3. Ensure that its optional features (e.g. yarn_pnp) still function as expected.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
6. package.json:21
  • Draft comment:
    Bump pnpm version to 10.9.0. Verify build scripts remain compatible with the updated package manager.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_URSuWJEybe0ve1PS

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 23, 2025

CodSpeed Performance Report

Merging #91 will not alter performance

Comparing chore/bump (23b37af) with main (a863a07)

Summary

✅ 3 untouched benchmarks

@JounQin JounQin merged commit 610d9f3 into main Apr 23, 2025
23 checks passed
@JounQin JounQin deleted the chore/bump branch April 23, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent resolution failure with yarn pnp

2 participants