test: add case for import-js/eslint-import-resolver-typescript#429#76
test: add case for import-js/eslint-import-resolver-typescript#429#76
Conversation
WalkthroughA new test case has been added to the Changes
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
The PR adds a failing test case to capture a specific edge-case in module resolution related to .d.ts files for .ts files.
- Introduces a new test tuple to validate the expected resolution of "./bar.ts" to "bar.d.ts".
- Enhances the test suite for resolving file extensions.
Comments suppressed due to low confidence (1)
src/tests/extensions.rs:98
- [nitpick] Consider adding an inline comment explaining the rationale behind expecting .d.ts to be resolved from a .ts file, to improve clarity for future maintainers.
("should resolve .d.ts for .ts", "./bar.ts", "bar.d.ts"),
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
08e0b6a to
de19677
Compare
|
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to de19677 in 55 seconds. Click for details.
- Reviewed
45lines of code in3files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/specifier.rs:25
- Draft comment:
Typo fix: Renamingparse_query_framgmenttoparse_query_fragmentimproves clarity. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. src/tests/extensions.rs:91
- Draft comment:
New test case for alias resolution: Validates that './bar.ts' correctly resolves to 'bar.d.ts'. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. src/specifier.rs:25
- Draft comment:
Typo fix: renamed call from 'parse_query_framgment' to 'parse_query_fragment', enhancing readability. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, pointing out a typo fix that enhances readability. It does not provide a suggestion, ask for confirmation, or highlight a potential issue.
4. src/tests/extensions.rs:101
- Draft comment:
New test case added to verify that extension aliasing correctly resolves '.ts' requests to '.d.ts' when no '.ts' file exists. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, describing a new test case that was added. It does not provide any suggestions, ask for confirmation, or point out any issues.
5. src/specifier.rs:32
- Draft comment:
Typographical error was present in the function name (parse_query_framgment). It has been corrected to parse_query_fragment. This ensures consistency and improves code readability. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, pointing out a typographical correction. It doesn't suggest any action or ask for confirmation about the change. It simply states what was done and why, which violates the rule against purely informative comments.
Workflow ID: wflow_hgjJx9gCAfhQQF6E
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 93.22% 93.22%
=======================================
Files 13 13
Lines 2850 2850
=======================================
Hits 2657 2657
Misses 193 193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #76 will not alter performanceComparing Summary
|
Summary by CodeRabbit
.tsfiles correctly resolve to.d.tsfiles, enhancing coverage of file extension resolution behavior.Important
Add test for
.tsto.d.tsresolution and fix typo inparse_query_fragment()function name.extensions.rsto verify.tsfiles resolve to.d.tsfiles.parse_query_fragment()function name inspecifier.rs.This description was created by
for de19677. You can customize this summary. It will automatically update as commits are pushed.