Conversation
WalkthroughThis update removes the query parameter handling support from the codebase. The Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Resolver
Client->>Resolver: Request module (e.g., "export-query/add?query1?query2")
Resolver-->>Client: Process request (no query handling)
Resolver-->>Client: Return "not found" error
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
💤 Files with no reviewable changes (6)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (4)
- fixtures/enhanced_resolve/test/fixtures/export-query/add.js?query: Language not supported
- fixtures/enhanced_resolve/test/fixtures/export-query/equal.js?query: Language not supported
- fixtures/enhanced_resolve/test/fixtures/export-query/minus.js?query: Language not supported
- fixtures/enhanced_resolve/test/fixtures/export-query/package.json: Language not supported
Comments suppressed due to low confidence (1)
src/tests/exports_field.rs:57
- [nitpick] The test description 'should resolve with query string #10' is used repeatedly for different cases. Consider adding distinguishing details to each test case to aid in identifying failure points.
("should resolve with query string #10", f6.clone(), "export-query/add?query", f6.join("add.js?query1?query2")),
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 92.75% 93.03% +0.28%
==========================================
Files 13 13
Lines 2842 2830 -12
==========================================
- Hits 2636 2633 -3
+ Misses 206 197 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #53 will not alter performanceComparing Summary
|
which is already handled by oxc-project/oxc-resolver#443
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which is already handled by oxc-project/oxc-resolver#443
Summary by CodeRabbit