Eslint cleanup by Myestery · Pull Request #14595 · unlock-protocol/unlock

Myestery · 2024-09-11T16:57:22Z

Description

Ensure consistent eslint rules across all packages, also ensure commands are same and reused in all package.jsons

Issues

Fixes #14564
Refs #14564

Checklist:

1 PR, 1 purpose: my Pull Request applies to a single purpose
I have commented my code, particularly in hard-to-understand areas
I have updated the docs to reflect my changes if applicable
I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
I have performed a self-review of my own code
If my code involves visual changes, I am adding applicable screenshots to this thread

…ed warning

locksmith/scripts/connectedPurchase.ts

locksmith/scripts/metadataUpload/user_metadata_upload.ts

packages/networks/eslint.config.js

…ummed warning This commit synchronizes the eslint rules and updates the evm-address-to-checksummed warning. It also fixes the formatting of recipient and userAddress variables to use checksummed addresses. Fixes unlock-protocol#14592

packages/core/eslint.config.js

packages/networks/eslint.config.js

julien51

I am genuinely surpirsed that more things are not breaking with all the rules being removed. Were these rules not used at all?

Myestery · 2024-09-11T19:54:35Z

I am genuinely surpirsed that more things are not breaking with all the rules being removed. Were these rules not used at all?

The no-require rule was moved to the base config in the last PR, while some rules were not really used.
A couple of them are still important and exist as seen in the unlock-app package
I believe some of these rules are now part of the default in eslint v9

julien51 · 2024-09-12T15:39:23Z

ok, one more thing. I see there is at least one duplicated rule between the base and the next config. Can you remove the duplicate from the next config.
Also, can you please check that all rules in base and next are needed and remove them if not?
Thanks!

…nd unused imports

…otocol#14594) timezone set by deafault based on location

improve ux for resolving address or name inputs

* add UpdateEmailModal component * strip attendee specific actions from locks' view * strip unnwanted metadata and add specific event actions to attendees' view * linting * update lock settings metadata card to include email actions

…#14598)

Myestery · 2024-09-12T18:26:25Z

Hi @julien51 I've been able to sync the rules between the eslint config files and remove unnecessary ones

julien51 · 2024-09-12T19:13:17Z

Great! Tahnsk a lot!

This reverts commit 3129cbb.

Revert "Eslint cleanup (#14595)" This reverts commit 3129cbb.

Myestery added 3 commits September 11, 2024 17:42

feat (lint): synchronize eslint rules

ec560e5

feat (lint): synchronize eslint rules

b38b4b3

feat (lint): synchronize eslint rules

0d9f6e0

cla-bot bot added the cla-signed label Sep 11, 2024

Myestery changed the title ~~Eslint-cleanup~~ Eslint cleanup Sep 11, 2024

feat(lint): Synchronize eslint rules and add evm-address-to-checksumm…

7370c64

…ed warning