Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.44%. Comparing base (d32b5dd) to head (9de6a7e).
⚠️ Report is 14 commits behind head on dev/v4-fin.

@@             Coverage Diff             @@
##           dev/v4-fin     #434   +/-   ##
===========================================
  Coverage       58.44%   58.44%           
===========================================
  Files              12       12           
  Lines            1865     1865           
===========================================
  Hits             1090     1090           
  Misses            775      775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Greptile Summary

This PR improves the Uniswap v4 Python library with case-insensitive address comparisons, variable renaming for clarity, multi-hop quoter tests, and minor housekeeping. However, a logic regression in encode_path_keys_input reverses the multi-hop path for exact-input quotes, which needs to be reverted before merging.

Key changes:

• .lower() comparison fix (correct): All eight token-ordering guards (if token0 > token1) across StateView, quoter, and swap functions are updated to use .lower(). Without this, checksummed addresses (e.g. \"0xA0b8...\") could sort differently than their lowercase equivalents, leading to wrong pool key derivation.
• encode_path_keys_input regression (P1): encoded_path.append(path_key) was changed to encoded_path.insert(0, path_key). Since this function iterates path in forward order, insert-at-front produces a reversed list. The Uniswap v4 V4Quoter consumes the path in forward order, so a reversed list causes the quoter to look up the wrong pool for the first hop on any 2+ hop path.
• Multi-hop tests added: New 2-hop get_quote_exact_input and get_quote_exact_output tests are added (ETH → USDC → USDT). The exactInput 2-hop test will fail or produce wrong results due to the regression above.
• Unused fee parameter removed from make_swap_input / make_swap_output public methods (the fee is already carried by swap_pool_key).
• Test variable renaming: test_token0/test_token1 → test_ETH/test_USDC/test_USDT improves readability.

Confidence Score: 4/5

Not safe to merge as-is — a single-line regression in encode_path_keys_input reverses multi-hop exact-input paths and must be reverted.

All other changes (8× .lower() fix, variable renames, removed unused parameter, comment cleanup, new tests) are correct and valuable. The one P1 issue — append replaced by insert(0,...) in encode_path_keys_input — silently breaks any 2+ hop quoteExactInput call. Single-hop paths are unaffected, meaning existing 1-hop tests still pass and the regression can easily go unnoticed. Reverting that single line restores correct behaviour and makes the PR mergeable.

uniswap/uniswap4.py line 1502 (encode_path_keys_input)

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant Caller
    participant get_quote_exact_input
    participant encode_path_keys_input
    participant V4Quoter

    Caller->>get_quote_exact_input: (ETH, qty, [ETH-USDC pool, USDT-USDC pool])
    get_quote_exact_input->>encode_path_keys_input: (path=[ETH-USDC, USDT-USDC], currency_in=ETH)

    Note over encode_path_keys_input: OLD (correct): append<br/>→ [PathKey(USDC,fee1), PathKey(USDT,fee2)]

    Note over encode_path_keys_input: NEW (regression): insert(0,...)<br/>→ [PathKey(USDT,fee2), PathKey(USDC,fee1)] REVERSED

    encode_path_keys_input-->>get_quote_exact_input: encoded_path

    get_quote_exact_input->>V4Quoter: quoteExactInput({ETH, encoded_path, qty})

    Note over V4Quoter: hop[0]: inputCurrency=ETH + PathKey(USDT,fee2)<br/>→ looks for ETH-USDT pool (WRONG)

    V4Quoter-->>get_quote_exact_input: revert / wrong quote
    get_quote_exact_input-->>Caller: error

_{Reviews (1): Last reviewed commit: "Checks improvements, small logic fix, mu..." | Re-trigger Greptile}