Attempt a couple type error improvements #5837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tweaks to type checking aspects to attempt to get nicer errors. 1. Remove the `InMatch` scope from the _checking_ path. This causes the error extractor that reports incoherent branch types from triggering, so that you don't get the error when _annotating_ the match with a different type. This is similar to how if statements are set up, which didn't seem subject to the same problem. 2. Add an `InActionRestriction` scope to the checker and use it around subtyping checks against `Unit` in blocks. This allows us to match the extra scope information and report a customized error. This allows circumventing another situation where the block failure would be reported as a "branches have different types" error when it happened inside a match, even though that makes no sense.
aryairani
approved these changes
Aug 14, 2025
Contributor
|
Oh gosh. Github's auto-merge doesn't wait for CI. What a useless feature. |
Contributor
Author
|
So, wait, are there still CI failures from this? |
Contributor
|
@dolio Yes; looks like probably a merge issue with trunk and the transcript. |
aryairani
added a commit
that referenced
this pull request
Aug 14, 2025
Missing transcript update from #5837
Member
There's some way to tweak those settings; it works great in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks to type checking aspects to attempt to get nicer errors.
Remove the
InMatchscope from the checking path. This causes the error extractor that reports incoherent branch types from triggering, so that you don't get the error when annotating the match with a different type. This is similar to how if statements are set up, which didn't seem subject to the same problem.Add an
InActionRestrictionscope to the checker and use it around subtyping checks againstUnitin blocks. This allows us to match the extra scope information and report a customized error.This allows circumventing another situation where the block failure would be reported as a "branches have different types" error when it happened inside a match, even though that makes no sense.
Fixes #5283 and #5217