Add transcripts.in-place
#5819
Merged
Add transcripts.in-place
#5819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
commented
Aug 1, 2025
| pure tmp | ||
| -- | Prep the codebase for transcripts, then pass the directory to the action. | ||
| -- After the action the codebase will be deleted/copied/saved as indicated. | ||
| withTranscriptDir :: Verbosity.Verbosity -> String -> TranscriptCodebaseSetup -> Maybe CodebasePathOption -> (FilePath -> IO r) -> IO (Maybe r) |
Member
Author
There was a problem hiding this comment.
Apologies for the noisy refactor here, I switched it to use bracket to ensure proper cleanup.
Contributor
|
Oh lovely |
sellout
added a commit
to sellout/unison
that referenced
this pull request
Aug 28, 2025
The interpreter tests are broken by unisonweb#5819 which (wisely) fails `transcript.fork` when it’s run with the same source and target codebase. This updates the interpreter tests to use `transcript.in-place` instead.
sellout
added a commit
to sellout/unison
that referenced
this pull request
Aug 28, 2025
The interpreter tests are broken by unisonweb#5819 which (wisely) fails `transcript.fork` when it’s run with the same source and target codebase. This updates the interpreter tests to use `transcript.in-place` instead. (cherry picked from commit dc61f22)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A feature requested by Paul and Cody, also see here: https://discord.com/channels/862108724948500490/1200119435931942994/1400567949357617302
This allows you to simply specify
ucm transcript.in-place -c fooand it will run the transcript onfooin-place.This uses the default codebase if unspecified, and will create a new codebase, then modify it if passed with
-Cto a codebase which doesn't already exist.If the old workaround of
transcript.fork -S codebase -C codebaseis provided, this will now issue a warning suggesting to usetranscript.in-placeexplicitly instead.Implementation notes
We now get:
If the path is outside of the current dir It will remain an absolute path as you'd expect.
Test coverage
I tested manually:
transcript.in-placetranscript.in-placetranscript.in-placetranscript.fork, and getting a warning. (Also tried with mismatched but canonically equal paths, like relative vs absolute, etc.)transcript.forkto ensure it still workstranscriptto ensure it still works