Set file.result when processing to non-text#87
Merged
Conversation
unified is typically, but not always, used to *serialize* when it compiles. Compilers don’t always return such a serialized (`string`, `Buffer`) though. The previous behavior was to place the result of the stringify phase when processing on `file.contents`. This doesn’t make sense for non-text. This change places non-text results on `file.result`. Closes vfile/vfile#45.
Member
Author
Not handled differently. It’s a non-text (neither string nor buffer), so it goes into Nully values are ignored (so a compiler could signal that the current |
wooorm
added a commit
to unifiedjs/unified-engine
that referenced
this pull request
Mar 26, 2020
Related to vfile/vfile#45. Related to unifiedjs/unified#87.
wooorm
added a commit
to unifiedjs/unified-engine
that referenced
this pull request
Mar 26, 2020
Related to vfile/vfile#45. Related to unifiedjs/unified#87. Closes GH-45. Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unified is typically, but not always, used to serialize when it compiles. Compilers don’t always return such a serialized (
string,Buffer) though. The previous behavior was to place the result of the stringify phase when processing onfile.contents. This doesn’t make sense for non-text. This change places non-text results onfile.result.Closes vfile/vfile#45.