ICU-21591 Release lock in SimpleDateFormat::tzFormat in case of failure#1701
Merged
aheninger merged 1 commit intounicode-org:mainfrom Apr 28, 2021
Merged
Conversation
Contributor
Author
|
Followup replacement for #1699. Hoping to avoid making extra work for filipnavara, who identified the original problem. |
7 tasks
markusicu
reviewed
Apr 26, 2021
Also remove the use of the unsafe double-checked lock idiom in the same function, SimpleDateFormat::tzFormat(). Synchronization now always uses a mutex, which is slower, but in the context of format or parse operations, shouldn't be significant. Added synchronization to one more unsafe direct reference to a const SimpleDateFormat::fTimeZoneFormat. In the assignment operator.
a71260c to
137b314
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
5 tasks
daniel-ju
added a commit
to microsoft/icu
that referenced
this pull request
May 3, 2021
Cherry-pick: ICU-21591 Release lock in SimpleDateFormat::tzFormat in case of failure This cherry-picks the upstream fix to resolve the deadlock in SimpleDateFormat::tzFormat. Upstream ticket: https://unicode-org.atlassian.net/browse/ICU-21591 Upstream PR: unicode-org/icu#1701
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove the use of the unsafe double-checked lock idiom in the same
function, SimpleDateFormat::tzFormat(). Synchronization now always uses a
mutex, which is slower, but in the context of format or parse operations,
shouldn't be significant.
Added synchronization to one more unsafe direct reference to a const
SimpleDateFormat::fTimeZoneFormat. In the assignment operator.
Checklist