ICU-21461 uprops.h: remove unused gc macros#1555
Merged
markusicu merged 1 commit intounicode-org:masterfrom Feb 2, 2021
Merged
ICU-21461 uprops.h: remove unused gc macros#1555markusicu merged 1 commit intounicode-org:masterfrom
markusicu merged 1 commit intounicode-org:masterfrom
Conversation
and some underused character constants
jefgen
approved these changes
Feb 2, 2021
Member
jefgen
left a comment
There was a problem hiding this comment.
lgtm, thanks for cleaning this up! 😄
jefgen
added a commit
to microsoft/icu
that referenced
this pull request
Mar 5, 2021
This change cherry-picks the upstream fix to remove macros that use names which are reserved by the C++ standard. There are upcoming changes to the MSVC STL headers which will use some of these reserved names, which causes conflicts. Upstream PR: unicode-org/icu#1555 Upstream ticket: https://unicode-org.atlassian.net/browse/ICU-21461
jefgen
added a commit
to microsoft/icu
that referenced
this pull request
Mar 5, 2021
This change cherry-picks the upstream fix to remove macros that use names which are reserved by the C++ standard. There are upcoming changes to the MSVC STL headers which might use some of these reserved names, which causes conflicts. Upstream PR: unicode-org/icu#1555 Upstream ticket: https://unicode-org.atlassian.net/browse/ICU-21461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and some underused character constants
https://unicode-org.atlassian.net/browse/ICU-21461
It turned out that the gc macros were not used. (They probably were used some time ago.)
There were also some adjacent character constants (as enum constants) that are less useful now that we can use Unicode character literals. I removed some that were used in only one or two places.