CLDR-16439 zone alias South_Pole was moved to McMurdo, so remove it from Auckland#4592
Merged
pedberg-icu merged 1 commit intounicode-org:mainfrom Apr 9, 2025
Conversation
6adb143 to
ce432d4
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
conradarcturus
approved these changes
Apr 9, 2025
Contributor
Author
|
Thanks Conrad! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLDR-16439
PR #4535 added the secondary zone alias South_Pole for McMurdo, but did not remove it from its previous entry for Auckland. That caused a serious problem in the timezoneTypes array generated for ICU which tries to map legacy zone IDs to modern one; it was trying to map South_Pole to 2 different IDs, so the resource could not be read and all mapping of BCP47 keys and types was broken. So this PR removes the old alias. I will also file a ticket for a unit test to check this sort of thing.
ALLOW_MANY_COMMITS=true