feat(lessons/12): use luxon instead of moment#15
Conversation
|
Please keep the JavaScript snippets in CJS for now. I'll do everything at once to ESM for #7, but having one page be ESM and the rest CJS won't be a great experience. |
|
I am unsure how the progress going for that is but if you want, I can make the updates up to Lesson17 (pretty much just HTML component as that was as far as I got) for ESM if you haven't gotten around to that yet and could potentially keep this open until then. Otherwise I'll get around to converting this back to CJS later today. |
Not much unfortunately, I don't have all that much time to spend on this project these days besides reviewing contributions like this one! I would love if you could update the rest of them - you can either leave this PR open and raise a new one converting every other lesson to CJS besides lesson 12, then merge both at the same-ish time, or you could convert this to CJS, I can merge soon, and then the full ESM rewrite could be merged later down the road. Up to you. |
|
Can you add me in your project? |
What does this mean? |
|
Thanks so much for working on this! |
Co-authored-by: uncenter <uncenter@uncenter.dev>
This contains the library update from Moment to Luxon. Just a heads up however that the code snippets provided have also been updated to use ESM over CJS for both the filters and Eleventy configuration file. I have altered some of the content to briefly describe how Luxon works as well as the
OrdinalDay()function. I also included an info box briefly talking about the past implementation of Moment and why the change to Luxon was made.