Add typing and expose py.typed#135
Merged
un33k merged 1 commit intoun33k:stagingfrom Oct 9, 2023
DanielNoord:add-typing
Merged
Add typing and expose py.typed#135un33k merged 1 commit intoun33k:stagingfrom DanielNoord:add-typing
py.typed#135un33k merged 1 commit intoun33k:stagingfrom
DanielNoord:add-typing
Conversation
Owner
|
@DanielNoord this is great. Would it be possible to point the PR to |
Contributor
Author
|
@un33k Changed the base. There seem to be no conflicts? But feel free to rebase this branch on Edit: Never mind. Thanks for merging! |
un33k
added a commit
that referenced
this pull request
Oct 9, 2023
* Add typing and expose ``py.typed`` (#135) * actions order * Revert "actions order" This reverts commit 716c2c7. * Revert "Merge branch 'master' into staging" This reverts commit e1699be, reversing changes made to c3fe574. --------- Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds typing to the package and exposes a
py.typedfile.There is one change where
add_uppercase_charreturnschar_listif the otherreturnstatement is never met. This seems intended, the function returningNonedoesn't seem like what is intended with the code.Let me know if I need to make any changes!
The tests passed with this change on
3.7.