Skip to content

NOISSUE - Simplify local agent running in non sev-snp environment#411

Merged
drasko merged 5 commits into
ultravioletrs:mainfrom
SammyOina:agent-non-tpm
Apr 1, 2025
Merged

NOISSUE - Simplify local agent running in non sev-snp environment#411
drasko merged 5 commits into
ultravioletrs:mainfrom
SammyOina:agent-non-tpm

Conversation

@SammyOina

@SammyOina SammyOina commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

What type of PR is this?

this an agent refactor to add stop event and simplify running agent locally

What does this do?

  • New Features
    • Enhanced logging capabilities within the VM management process.
    • Introduced customizable attestation functionality and provider setups.
  • Refactor
    • Streamlined service initialization and dependency management for enhanced reliability and adaptability.
  • Bug Fixes
    • Corrected mock function signatures to improve type safety and clarity in testing.
  • Documentation
    • Updated comments to reflect changes in mock function parameters and tool versions.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…logger

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina SammyOina changed the title Agent non tpm NOISSUE - Simplify local agent running in non sev-snp environment Mar 21, 2025
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@codecov

codecov Bot commented Mar 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 37.93103% with 18 lines in your changes missing coverage. Please review.

Project coverage is 55.08%. Comparing base (ebe1196) to head (e0f89f0).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
manager/api/grpc/server.go 0.00% 5 Missing ⚠️
agent/service.go 33.33% 4 Missing ⚠️
agent/cvms/server/cvm.go 0.00% 3 Missing ⚠️
cli/manager.go 0.00% 3 Missing ⚠️
pkg/attestation/vtpm/vtpm.go 0.00% 2 Missing ⚠️
manager/service.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   55.14%   55.08%   -0.06%     
==========================================
  Files          60       60              
  Lines        5239     5241       +2     
==========================================
- Hits         2889     2887       -2     
- Misses       2047     2050       +3     
- Partials      303      304       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…e layers

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@dborovcanin

Copy link
Copy Markdown
Contributor

@smithjilks @WashingtonKK @danko-miladinovic Please review.

@dborovcanin

Copy link
Copy Markdown
Contributor

@danko-miladinovic Please also take a look.

@danko-miladinovic danko-miladinovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 7e63921 into ultravioletrs:main Apr 1, 2025
dborovcanin pushed a commit that referenced this pull request Apr 2, 2025
* Initial commit, will be tested before creating a PR

* Initial commit, will be tested before creating a PR

* Fixed all issues

* Initial commit, will be tested before creating a PR

* Updated agent docs

* Fixed based on comments

* Fixed based on comments

* Initial commit, will be tested before creating a PR

* Updated agent docs

* Fixed based on comments

* Fixed based on comments

* added certificate verification

* Initial commit, will be tested before creating a PR

* Fixed all issues

* Initial commit, will be tested before creating a PR

* Initial commit, will be tested before creating a PR

* Updated agent docs

* Fixed based on comments

* Fixed based on comments

* added certificate verification

* Fixed rebase errors

* Fixed proto issues

* fixed proto issues

* Fixed format error

* Fixed based on comments

* NOISSUE - Simplify local agent running in non sev-snp environment (#411)

* Add vtpm attestation support to agent service and server

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

* Update mockery version to v2.53.2 and refactor VM factory to include logger

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

* Send event notification when computation is stopped in agentService

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

* Remove redundant assignment of Stderr in qemuVM Start method

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

* Rename SVM references to CVM in tracing, logging, metrics, and service layers

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

---------

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

* Bump github.com/docker/docker (#416)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 28.0.1+incompatible to 28.0.4+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v28.0.1...v28.0.4)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google.golang.org/protobuf from 1.36.5 to 1.36.6 (#412)

Bumps google.golang.org/protobuf from 1.36.5 to 1.36.6.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* COCOS-393 - Disable SSH service and update user shell in cloud config (#396)

* Disable SSH service and update user shell in cloud config

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

* Remove SSH server and clean up dependencies in cloud config

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

* Add firewall configuration and ensure iptables rules persist after reboot

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

* Add algo_user configuration and setup script for container execution

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

---------

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

* Initial commit, will be tested before creating a PR

* Fixed all issues

* Initial commit, will be tested before creating a PR

* Initial commit, will be tested before creating a PR

* Fixed based on comments

* Fixed based on comments

* added certificate verification

* Initial commit, will be tested before creating a PR

* Fixed all issues

* Initial commit, will be tested before creating a PR

* Initial commit, will be tested before creating a PR

* Fixed based on comments

* Fixed rebase errors

* Fixed format error

* Fixed based on comments

* Fixed rebase errors

---------

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants