COCOS-390 - Add IGVM measurement on manager#404
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 56.88% 56.67% -0.21%
==========================================
Files 59 59
Lines 5058 5078 +20
==========================================
+ Hits 2877 2878 +1
- Misses 1882 1900 +18
- Partials 299 300 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SammyOina
requested changes
Mar 12, 2025
| } | ||
| case vmi.Config.EnableSEVSNP: | ||
| measurement, err = guest.CalcLaunchDigest(guest.SEV_SNP, vmi.Config.SMPCount, uint64(cpuid.CpuSigs[vmi.Config.CPU]), vmi.Config.OVMFCodeConfig.File, vmi.Config.KernelFile, vmi.Config.RootFsFile, strconv.Quote(qemu.KernelCommandLine), defGuestFeatures, "", vmmtypes.QEMU, false, "", 0) | ||
| args := []string{} |
Contributor
There was a problem hiding this comment.
use the
to execute the measurement calculation command
SammyOina
requested changes
Mar 12, 2025
Comment on lines
+87
to
+91
| err = igvmMeasurement.Run(ms.qemuCfg.IGVMConfig.File) | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| err = igvmMeasurement.Run(ms.qemuCfg.IGVMConfig.File) | |
| if err != nil { | |
| return nil, err | |
| } | |
| if err = igvmMeasurement.Run(ms.qemuCfg.IGVMConfig.File);err != nil { | |
| return nil, err | |
| } |
Comment on lines
+81
to
85
| igvmMeasurement, err := igvmmeasure.NewIgvmMeasurement(igvmMeasurementBinaryPath, stderr, stdout) | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| igvmMeasurement, err := igvmmeasure.NewIgvmMeasurement(igvmMeasurementBinaryPath, stderr, stdout) | |
| if err != nil { | |
| return nil, err | |
| } | |
| igvmMeasurement, err := igvmmeasure.NewIgvmMeasurement(igvmMeasurementBinaryPath, stderr, stdout) | |
| if err != nil { | |
| return nil, err | |
| } |
SammyOina
approved these changes
Mar 12, 2025
dborovcanin
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature and a documentation update.
What does this do?
The method
FetchAttestationPolicyhas been update. Now in the case of SEV-SNP it measures the IGVM file.Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No.
Did you document any new/modified feature?
Manager README.md file was modified since it is now expected that
MANAGER_ATTESTATION_POLICY_BINARYvariable points to a directory that includes theigvmmeasurebinary.Notes