Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 56.66% 56.88% +0.21%
==========================================
Files 58 59 +1
Lines 4998 5058 +60
==========================================
+ Hits 2832 2877 +45
- Misses 1868 1882 +14
- Partials 298 299 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SammyOina
requested changes
Feb 24, 2025
SammyOina
requested changes
Feb 26, 2025
SammyOina
requested changes
Feb 28, 2025
SammyOina
requested changes
Mar 4, 2025
SammyOina
approved these changes
Mar 6, 2025
dborovcanin
requested changes
Mar 10, 2025
SammyOina
requested changes
Mar 11, 2025
SammyOina
requested changes
Mar 11, 2025
Add copyright information to package Add testing to igvm measurements Remove trailing white space Improve testing Resolve PR comments Add measure to cli Add README for feature Fix PR comments Added new line to shell script Add measurement interface Fix ci Refactor code for IgvmMeasurement to become a CLI dependency Refactor code for IgvmMeasurement to become a CLI dependency Refactor based on ci failures Fix error handling Add header Fix ci
SammyOina
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality: Igvm measurement functionality
What does this do?
Change the CLI so it calculates the measurement based on the vTPM and OVMF used.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests.
Did you document any new/modified feature?
No, I have not updated the documentation but I will focus on documentation next.