Skip to content

NOISSUE - Simplify manager to vm provision only#353

Merged
dborovcanin merged 14 commits into
ultravioletrs:mainfrom
SammyOina:cocos-344-b
Jan 20, 2025
Merged

NOISSUE - Simplify manager to vm provision only#353
dborovcanin merged 14 commits into
ultravioletrs:mainfrom
SammyOina:cocos-344-b

Conversation

@SammyOina

@SammyOina SammyOina commented Jan 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

What does this do?

  • New Features

    • Added support for creating and removing virtual machines via CLI
    • Introduced new gRPC methods for VM management
    • Enhanced CLI with VM-related commands

  • Changes

    • Refactored service architecture to focus on VM management
    • Removed event logging and computation-related functionalities
    • Simplified error handling and SDK initialization processes

  • Removals

    • Eliminated vsock event handling mechanisms
    • Removed computation-specific logging and tracking
    • Discontinued certain middleware and event management components

  • Infrastructure

    • Updated gRPC service definitions
    • Modified client configuration structures
    • Streamlined dependency management

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

to be merged after #350

image

@codecov

codecov Bot commented Jan 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 17.94872% with 96 lines in your changes missing coverage. Please review.

Project coverage is 62.28%. Comparing base (ecad651) to head (1385a02).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/manager.go 0.00% 44 Missing ⚠️
manager/api/grpc/server.go 0.00% 31 Missing ⚠️
cli/sdk.go 0.00% 16 Missing ⚠️
manager/service.go 72.22% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   65.41%   62.28%   -3.13%     
==========================================
  Files          57       54       -3     
  Lines        4756     4261     -495     
==========================================
- Hits         3111     2654     -457     
+ Misses       1360     1344      -16     
+ Partials      285      263      -22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SammyOina
new agent structure
8f36600 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix lint
2a16ac7 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix tests
94ab7a9 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
cvm tests fix
30632eb 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix test
53494f8 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
manager server, for vm provisioning
bd49bbd 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix lint
a1fdf02 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
add cli and test
83aeade 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
restore result cli
373e602 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix tests
2c28dd7 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix failing tests
7dda16b 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix failing test
93a265d 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
refactor: remove context from docker struct and use local context in …
3d7895c 
…Run method

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
delete: remove unused gRPC API and related server implementation
1385a02 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@dborovcanin dborovcanin merged commit 1f32f51 into ultravioletrs:main Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dborovcanin dborovcanin dborovcanin approved these changes
@smithjilks smithjilks smithjilks approved these changes
@drasko drasko Awaiting requested review from drasko

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SammyOina @dborovcanin @smithjilks