COCOS-344 - New agent structure by SammyOina · Pull Request #350 · ultravioletrs/cocos

SammyOina · 2025-01-09T16:47:29Z

What type of PR is this?

What does this do?

New Features
- Added support for CVM (Confidential Virtual Machine) service with gRPC streaming capabilities
- Introduced new methods for initializing and stopping computations
- Enhanced event logging and metrics tracking for computation lifecycle
Improvements
- Refactored event handling to use message queues instead of direct connections
- Updated algorithm execution to support better process management
- Simplified configuration management using environment variables
Breaking Changes
- Removed AgentConfig from computation configurations
- Changed gRPC client and service interfaces
- Modified event sending mechanism to include computation ID
Bug Fixes
- Improved error handling in algorithm execution
- Enhanced logging and metrics instrumentation

Which issue(s) does this PR fix/relate to?

Resolves Feature: Design architecture for Agent direct connection to cloud #344

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

codecov · 2025-01-10T12:10:42Z

Codecov Report

Attention: Patch coverage is 58.50340% with 183 lines in your changes missing coverage. Please review.

Project coverage is 65.41%. Comparing base (59b8057) to head (14f4841).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
agent/cvms/api/grpc/client.go	73.37%	34 Missing and 11 partials ⚠️
agent/cvms/server/cvm.go	0.00%	44 Missing ⚠️
agent/service.go	43.63%	28 Missing and 3 partials ⚠️
agent/algorithm/python/python.go	27.77%	11 Missing and 2 partials ⚠️
agent/algorithm/binary/binary.go	33.33%	11 Missing and 1 partial ⚠️
agent/algorithm/wasm/wasm.go	33.33%	12 Missing ⚠️
agent/cvms/api/grpc/server.go	85.71%	8 Missing and 2 partials ⚠️
pkg/clients/grpc/cvm/cvm.go	0.00%	6 Missing ⚠️
internal/logger/protohandler.go	75.00%	4 Missing and 1 partial ⚠️
agent/algorithm/docker/docker.go	33.33%	4 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   66.31%   65.41%   -0.91%     
==========================================
  Files          53       57       +4     
  Lines        4391     4756     +365     
==========================================
+ Hits         2912     3111     +199     
- Misses       1207     1360     +153     
- Partials      272      285      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

dborovcanin · 2025-01-17T09:20:24Z

+	}
+}
+
+type runRequestManager struct {


Is there a way to avoid implementing this chunk manager (proto/grpc lib or 3rd-party lib)?

proto/grpc does not support it, I have not found a third party lib at the moment, I just looked at the simple implementation for out use case

…Client to CVMSClient Signed-off-by: Sammy Oina <sammyoina@gmail.com>

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

… tests Signed-off-by: Sammy Oina <sammyoina@gmail.com>

…ice tests Signed-off-by: Sammy Oina <sammyoina@gmail.com>

SammyOina added 7 commits January 9, 2025 19:46

new agent structure

9f3c327

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

minor fixes and testing

20c214f

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

fix lint

de8c517

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

fix tests

410b214

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

cvm tests fix

70f9b7b

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

fix test

0016813

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

fix cli test

ce3a499

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

SammyOina requested review from dborovcanin and drasko January 10, 2025 12:15

smithjilks reviewed Jan 10, 2025

View reviewed changes

Comment thread agent/cvm/server/cvm.go Outdated

SammyOina mentioned this pull request Jan 10, 2025

NOISSUE - Simplify manager to vm provision only #353

Merged

rename

fa6816b

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

SammyOina requested a review from smithjilks January 13, 2025 13:25

smithjilks approved these changes Jan 14, 2025

View reviewed changes

rename cvm to cvms plural

41fd64e

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

drasko requested changes Jan 15, 2025

View reviewed changes

Comment thread agent/cvms/api/grpc/client.go Outdated

Comment thread agent/cvms/cvms.proto Outdated

dborovcanin requested changes Jan 16, 2025

View reviewed changes

Comment thread agent/algorithm/docker/docker.go Outdated

Comment thread agent/cvms/cvms.proto Outdated

rename service

9574e49

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

dborovcanin reviewed Jan 16, 2025

View reviewed changes

Comment thread pkg/clients/grpc/cvm/cvm.go

SammyOina added 2 commits January 16, 2025 14:03

fix tests

b63eefd

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

remove context

aa7f392

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

dborovcanin requested changes Jan 17, 2025

View reviewed changes

SammyOina added 5 commits January 17, 2025 12:36

refactor: reorder parameters in NewAlgorithm functions and update CVM…

13068c3

…Client to CVMSClient Signed-off-by: Sammy Oina <sammyoina@gmail.com>

fix(tests): update SendEvent mock to include an additional parameter

b55a332

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

move expectations

83a2b3f

Signed-off-by: Sammy Oina <sammyoina@gmail.com>

fix(tests): move event initialization to the correct scope in service…

1c6de68

… tests Signed-off-by: Sammy Oina <sammyoina@gmail.com>

fix(tests): update SendEvent mock to use EXPECT instead of On in serv…

14f4841

…ice tests Signed-off-by: Sammy Oina <sammyoina@gmail.com>

dborovcanin approved these changes Jan 17, 2025

View reviewed changes

dborovcanin merged commit ecad651 into ultravioletrs:main Jan 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

COCOS-344 - New agent structure#350

COCOS-344 - New agent structure#350
dborovcanin merged 17 commits into
ultravioletrs:mainfrom
SammyOina:cocos-344

SammyOina commented Jan 9, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Jan 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dborovcanin Jan 17, 2025

Uh oh!

SammyOina Jan 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

SammyOina commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Uh oh!

codecov Bot commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dborovcanin Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

SammyOina Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SammyOina commented Jan 9, 2025 •

edited

Loading

codecov Bot commented Jan 10, 2025 •

edited

Loading