[IN PROGRESS]: Upgrading the LeapCSharp api#928
Merged
Conversation
jselstad
reviewed
Jan 5, 2018
Contributor
jselstad
left a comment
There was a problem hiding this comment.
The essence of this change has been verified to work on my machine (in the editor and builds).
Contributor
|
@Amarcolina I would recommend that we merge the LeapCSharp source PR into this PR and then merge it into develop. That way we can dogfood it prior to the next release. The PR already has LeapC for Windows x64; LeapC.so for Android, and LeapCs for other platforms will come down the pipe closer to release, and will be validated by QA at the latest when we cut a release branch. |
added 3 commits
April 5, 2018 14:35
Replace LeapCSharp DLL with the actual LeapCSharp source code, bring tests back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress PR that aims to upgrade the image api to the new version that uses far less memory and copies than the previous. This is a change that requires the new service to use, so should not be merged/released until a new compatible service is available.
Changes:
Things left to do: