Skip to content

Replace LeapCSharp DLL with the actual LeapCSharp source code, bring tests back#983

Merged
vabrador merged 11 commits intofeature-upgraded-image-apifrom
feature-eat-leapcsharp
Apr 5, 2018
Merged

Replace LeapCSharp DLL with the actual LeapCSharp source code, bring tests back#983
vabrador merged 11 commits intofeature-upgraded-image-apifrom
feature-eat-leapcsharp

Conversation

@vabrador
Copy link
Copy Markdown
Contributor

@vabrador vabrador commented Mar 27, 2018

  • LeapCSharp is dead
  • Long live LeapCSharp
  • Verify all the examples are working and that builds don't accumulate memory indefinitely
  • Sanity-check the LeapCSharp source and make sure nothing crazy is in there
  • Make sure the LeapCSharp tests pass. Some are Ignore'd, the reasons should be sensible

I may go through and confirm that we don't have any dangling unused code like old ObjectPool and PooledObject, but this is ready for review.

@@ -0,0 +1,2 @@
AssemblyInfo.cs
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this gitignore need to be here? Those files are not needed anymore right?

@vabrador
Copy link
Copy Markdown
Contributor Author

vabrador commented Apr 5, 2018

meeergiiiing

@vabrador vabrador merged commit 8d55ae0 into feature-upgraded-image-api Apr 5, 2018
@Amarcolina Amarcolina deleted the feature-eat-leapcsharp branch April 19, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants