Skip to content

feat(overridesToOverride): backward compatibility for overrides#89

Merged
akudev merged 4 commits intomainfrom
override
Mar 13, 2023
Merged

feat(overridesToOverride): backward compatibility for overrides#89
akudev merged 4 commits intomainfrom
override

Conversation

@tobiasqueck
Copy link
Copy Markdown
Contributor

@tobiasqueck tobiasqueck commented Mar 13, 2023

Description

Thanks to #82 done by @akudev, it is possible to define controller extensions overrides nicely in with class syntax, however, it only works with very recent UI5 versions. To be backward compatible, I would like to add a configuration option allowing to convert overrides to override.

Contributes to fixing UI5/typescript#332

Tasks

  • add required logic to convert overrides to override if the option is true
  • add test case
  • updated documentation

@akudev
Copy link
Copy Markdown
Collaborator

akudev commented Mar 13, 2023

Thanks for the PR!

The code change looks good to me.

The documentation should IMO go to the list at:
https://github.com/ui5-community/babel-plugin-transform-modules-ui5#class-conversion

In general this documentation is a bit ahead of its time, as the "overrides" itself is not documented yet here - because it is not even documented in UI5 at all. But that's ok, just me a favor and add a short sentence to https://github.com/ui5-community/babel-plugin-transform-modules-ui5#handling-metadata-and-renderer to have the "overrides" handling itself mentioned.

Maybe after

This plugin allows you to configure metadata and renderer as class properties (static or not) and the plugin will convert it to object properties for the extend call.

Add something like:

The same happens for overrides in controller extensions.

Don't forget satisfying the commitlint check by declaring this a new feature in the PR .

@tobiasqueck tobiasqueck changed the title [PROPOSAL]: backward compatibility for overrides feat(overridesToOverride): backward compatibility for overrides Mar 13, 2023
@tobiasqueck tobiasqueck marked this pull request as ready for review March 13, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants