Add "overrides" to static props which go into the extend(...) object#82
Merged
r-murphy merged 1 commit intoui5-community:masterfrom Feb 11, 2023
akudev:master-overrides
Merged
Add "overrides" to static props which go into the extend(...) object#82r-murphy merged 1 commit intoui5-community:masterfrom akudev:master-overrides
r-murphy merged 1 commit intoui5-community:masterfrom
akudev:master-overrides
Conversation
This is needed for ControllerExtensions: the "overrides" block needs to go into the ControllerExtension.extend() call, not appended to the class later as a static property. Note that the name for this definition block is still "override" in the documentation at this time. But this is about to change, because a static property "override" clashes with the method ControllerExtension.override() in TypeScript. Contributes to fixing UI5/typescript#332
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for ControllerExtensions: the "overrides" block needs to go into the ControllerExtension.extend() call, not appended to the class later as a static property.
Note that the name for this definition block is still "override" in the documentation at this time. But this is about to change, because a static property "override" clashes with the method ControllerExtension.override() in TypeScript.
Contributes to fixing UI5/typescript#332