Skip to content

Multisite/single admins settings and cas version#6

Merged
figureone merged 1 commit into
uhm-coe:masterfrom
mackensen:cas-settings
Mar 21, 2016
Merged

Multisite/single admins settings and cas version#6
figureone merged 1 commit into
uhm-coe:masterfrom
mackensen:cas-settings

Conversation

@mackensen

Copy link
Copy Markdown
Contributor

There's a couple things in this pull request:

  1. Reduce code duplication by having a single function evaluating multisite or single admin.
  2. Define MULTISITE_ADMIN and SINGLE_ADMIN as constants for code readability.
  3. Check for MULTISITE_ADMIN for the newly-introduced cas_version, otherwise when you're at the network admin page the default value is selected regardless of what you've saved in the database.

@mackensen

Copy link
Copy Markdown
Contributor Author

The third of these was fixed in 99b0202 (thanks!)

@figureone

Copy link
Copy Markdown
Member

I hope to get a version released this week. It's spring break for us, so I should have a bit more free time. Thanks for your patience and contributions!

figureone added a commit that referenced this pull request Mar 21, 2016
Multisite/single admins settings and cas version
@figureone figureone merged commit 54ff9c7 into uhm-coe:master Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants